Adds a listener interface to HpackEncoder. Not used in production. Not protected.

Adds a listener interface to HpackEncoder. Not used in production. Not protected.

This CL lands server change 129028211 by birenroy.

BUG=488484
Committed: https://crrev.com/668b150d143c70f9b40444310da9f5658251a93e
Cr-Commit-Position: refs/heads/master@{#419236}

[yasong, 2016-08-12 20:00:39]

The CQ bit was checked by yasong@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-12 20:01:03]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-12 20:59:49]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-12 20:59:50]

Dry run: This issue passed the CQ dry run.

[yasong, 2016-08-12 21:25:47]

Description was changed from

==========
Adds a listener interface to HpackEncoder. Not used in production. Not
protected.

This CL lands server change 129028211 by birenroy.

BUG=488484
==========

to

==========
Adds a listener interface to HpackEncoder. Not used in production. Not
protected.

This CL lands server change 129028211 by birenroy.

BUG=488484
==========

[yasong, 2016-08-12 21:25:48]

yasong@chromium.org changed reviewers:
+ bnc@chromium.org

[yasong, 2016-08-12 21:26:44]

On 2016/08/12 21:25:48, yasong wrote:
> mailto:yasong@chromium.org changed reviewers:
> + mailto:bnc@chromium.org

Ready for review. Thanks!

[Bence, 2016-08-15 13:58:31]

LGTM with one nit.  Thank you.

https://codereview.chromium.org/2237113005/diff/1/net/spdy/hpack/hpack_encoder.h
File net/spdy/hpack/hpack_encoder.h (right):

https://codereview.chromium.org/2237113005/diff/1/net/spdy/hpack/hpack_encode...
net/spdy/hpack/hpack_encoder.h:23: using base::StringPiece;
Please remove this using directive.  Unfortunately they are not allowed in
header files.  (See "Do not use Namespace aliases at namespace scope in header
files except in explicitly marked internal-only namespaces" and "Don't put
namespace aliases in your public" at
https://google.github.io/styleguide/cppguide.html.)  This means that in every
header file, we have to spell out base::StringPiece.

[yasong, 2016-09-16 17:42:19]

The CQ bit was checked by yasong@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-16 17:42:42]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[yasong, 2016-09-16 17:43:55]

The CQ bit was checked by yasong@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-16 17:44:20]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[yasong, 2016-09-16 17:48:29]

The CQ bit was checked by yasong@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-16 17:49:05]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-16 18:48:39]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-16 18:48:40]

Dry run: This issue passed the CQ dry run.

[yasong, 2016-09-16 18:55:05]

On 2016/08/15 13:58:31, Bence wrote:
> LGTM with one nit.  Thank you.
> 
>
https://codereview.chromium.org/2237113005/diff/1/net/spdy/hpack/hpack_encoder.h
> File net/spdy/hpack/hpack_encoder.h (right):
> 
>
https://codereview.chromium.org/2237113005/diff/1/net/spdy/hpack/hpack_encode...
> net/spdy/hpack/hpack_encoder.h:23: using base::StringPiece;
> Please remove this using directive.  Unfortunately they are not allowed in
> header files.  (See "Do not use Namespace aliases at namespace scope in header
> files except in explicitly marked internal-only namespaces" and "Don't put
> namespace aliases in your public" at
> https://google.github.io/styleguide/cppguide.html.)  This means that in every
> header file, we have to spell out base::StringPiece.

Done. Thanks for the review!

[yasong, 2016-09-16 18:55:16]

The CQ bit was checked by yasong@chromium.org

[yasong, 2016-09-16 18:55:17]

The patchset sent to the CQ was uploaded after l-g-t-m from bnc@chromium.org
Link to the patchset: https://codereview.chromium.org/2237113005/#ps40001
(title: "Address Comments")

[commit-bot: I haz the power, 2016-09-16 18:55:36]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-16 19:03:11]

Description was changed from

==========
Adds a listener interface to HpackEncoder. Not used in production. Not
protected.

This CL lands server change 129028211 by birenroy.

BUG=488484
==========

to

==========
Adds a listener interface to HpackEncoder. Not used in production. Not
protected.

This CL lands server change 129028211 by birenroy.

BUG=488484
==========

[commit-bot: I haz the power, 2016-09-16 19:03:12]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-09-16 19:05:35]

Description was changed from

==========
Adds a listener interface to HpackEncoder. Not used in production. Not
protected.

This CL lands server change 129028211 by birenroy.

BUG=488484
==========

to

==========
Adds a listener interface to HpackEncoder. Not used in production. Not
protected.

This CL lands server change 129028211 by birenroy.

BUG=488484

Committed: https://crrev.com/668b150d143c70f9b40444310da9f5658251a93e
Cr-Commit-Position: refs/heads/master@{#419236}
==========

[commit-bot: I haz the power, 2016-09-16 19:05:36]

Patchset 3 (id:??) landed as
https://crrev.com/668b150d143c70f9b40444310da9f5658251a93e
Cr-Commit-Position: refs/heads/master@{#419236}