Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(184)

Issue 2237113004: Remove GN back-compat toolchain code for NaCl. (Closed)

Created:
4 years, 4 months ago by brettw
Modified:
4 years, 4 months ago
Reviewers:
Dirk Pranke, yzshen1
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove GN back-compat toolchain code for NaCl. Now that the NaCl side of the toolchain update has rolled in (this was https://codereview.chromium.org/2235083002/), the compatibility shim can be removed. BUG=634446 Committed: https://crrev.com/ca677516fc34e7a5004ba013f99499403d5d9994 Cr-Commit-Position: refs/heads/master@{#411737}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -23 lines) Patch
M build/toolchain/gcc_toolchain.gni View 1 chunk +0 lines, -23 lines 0 comments Download

Messages

Total messages: 16 (9 generated)
brettw
4 years, 4 months ago (2016-08-11 23:51:30 UTC) #2
brettw
4 years, 4 months ago (2016-08-12 19:24:35 UTC) #8
yzshen1
lgtm
4 years, 4 months ago (2016-08-12 19:35:35 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2237113004/1
4 years, 4 months ago (2016-08-12 19:39:39 UTC) #11
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 4 months ago (2016-08-12 19:43:41 UTC) #12
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/ca677516fc34e7a5004ba013f99499403d5d9994 Cr-Commit-Position: refs/heads/master@{#411737}
4 years, 4 months ago (2016-08-12 19:46:19 UTC) #14
Dirk Pranke
4 years, 4 months ago (2016-08-12 22:32:44 UTC) #16
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698