Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2237113002:
Removed unnecessary keep for ipc invalidation (Closed)
DescriptionRemoved unnecessary keep for ipc invalidation
See https://paste.googleplex.com/5558419184418816 for diff.
Saves us 35k of .dex size.
BUG=619937
Committed: https://crrev.com/8e197c064b8d2a8632e1489c3966004ff69b1c70
Cr-Commit-Position: refs/heads/master@{#411983}
Patch Set 1 #Patch Set 2 : rebased #Patch Set 3 : rebased #Messages
Total messages: 24 (15 generated)
Description was changed from ========== Removed unnecessary keep for ipc invalidation See https://paste.googleplex.com/5558419184418816 for diff. BUG=619937 ========== to ========== Removed unnecessary keep for ipc invalidation See https://paste.googleplex.com/5558419184418816 for diff. Saves us 35k of .dex size. BUG=619937 ==========
The CQ bit was checked by smaier@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
smaier@chromium.org changed reviewers: + agrieve@chromium.org
On 2016/08/11 20:11:56, smaier wrote: lgtm
The CQ bit was checked by smaier@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)
The CQ bit was checked by smaier@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from agrieve@chromium.org Link to the patchset: https://codereview.chromium.org/2237113002/#ps20001 (title: "rebased")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)
The CQ bit was checked by smaier@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from agrieve@chromium.org Link to the patchset: https://codereview.chromium.org/2237113002/#ps40001 (title: "rebased")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Message was sent while issue was closed.
Description was changed from ========== Removed unnecessary keep for ipc invalidation See https://paste.googleplex.com/5558419184418816 for diff. Saves us 35k of .dex size. BUG=619937 ========== to ========== Removed unnecessary keep for ipc invalidation See https://paste.googleplex.com/5558419184418816 for diff. Saves us 35k of .dex size. BUG=619937 ==========
Message was sent while issue was closed.
Committed patchset #3 (id:40001)
Message was sent while issue was closed.
Description was changed from ========== Removed unnecessary keep for ipc invalidation See https://paste.googleplex.com/5558419184418816 for diff. Saves us 35k of .dex size. BUG=619937 ========== to ========== Removed unnecessary keep for ipc invalidation See https://paste.googleplex.com/5558419184418816 for diff. Saves us 35k of .dex size. BUG=619937 Committed: https://crrev.com/8e197c064b8d2a8632e1489c3966004ff69b1c70 Cr-Commit-Position: refs/heads/master@{#411983} ==========
Message was sent while issue was closed.
Patchset 3 (id:??) landed as https://crrev.com/8e197c064b8d2a8632e1489c3966004ff69b1c70 Cr-Commit-Position: refs/heads/master@{#411983} |
