Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(10)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2237043003: Paint underline correctly in mixed flow text contexts with truncation (Closed)

Created:
4 years, 4 months ago by rhogan
Modified:
4 years, 4 months ago
Reviewers:
eae
CC:
blink-reviews, blink-reviews-paint_chromium.org, chromium-reviews, dshwang, slimming-paint-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@634445-2
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Paint underline correctly in mixed flow text contexts with truncation BUG=636060 Committed: https://crrev.com/673fa9cfdbf0fcefb6325aefd204cf6504cc37fd Cr-Commit-Position: refs/heads/master@{#411654}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+171 lines, -4 lines) Patch
M third_party/WebKit/LayoutTests/TestExpectations View 1 chunk +5 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/fast/text/ellipsis-ltr-text-in-ltr-flow-underline-composition.html View 1 chunk +23 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/fast/text/ellipsis-ltr-text-in-rtl-flow-underline-composition.html View 1 chunk +23 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/fast/text/ellipsis-rtl-text-in-ltr-flow-underline-composition.html View 1 chunk +23 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/fast/text/ellipsis-rtl-text-in-rtl-flow-underline-composition.html View 1 chunk +23 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/platform/linux/fast/text/ellipsis-ltr-text-in-ltr-flow-underline-composition-expected.png View Binary file 0 comments Download
A third_party/WebKit/LayoutTests/platform/linux/fast/text/ellipsis-ltr-text-in-ltr-flow-underline-composition-expected.txt View 1 chunk +16 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/platform/linux/fast/text/ellipsis-ltr-text-in-rtl-flow-underline-composition-expected.png View Binary file 0 comments Download
A third_party/WebKit/LayoutTests/platform/linux/fast/text/ellipsis-ltr-text-in-rtl-flow-underline-composition-expected.txt View 1 chunk +16 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/platform/linux/fast/text/ellipsis-rtl-text-in-ltr-flow-underline-composition-expected.png View Binary file 0 comments Download
A third_party/WebKit/LayoutTests/platform/linux/fast/text/ellipsis-rtl-text-in-ltr-flow-underline-composition-expected.txt View 1 chunk +17 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/platform/linux/fast/text/ellipsis-rtl-text-in-rtl-flow-underline-composition-expected.png View Binary file 0 comments Download
A third_party/WebKit/LayoutTests/platform/linux/fast/text/ellipsis-rtl-text-in-rtl-flow-underline-composition-expected.txt View 1 chunk +16 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/paint/InlineTextBoxPainter.cpp View 1 chunk +9 lines, -4 lines 0 comments Download

Messages

Total messages: 14 (8 generated)
rhogan
4 years, 4 months ago (2016-08-12 08:52:17 UTC) #7
rhogan
4 years, 4 months ago (2016-08-12 08:52:17 UTC) #8
eae
LGTM
4 years, 4 months ago (2016-08-12 14:17:02 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2237043003/1
4 years, 4 months ago (2016-08-12 14:17:23 UTC) #11
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 4 months ago (2016-08-12 15:11:47 UTC) #12
commit-bot: I haz the power
4 years, 4 months ago (2016-08-12 15:13:02 UTC) #14
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/673fa9cfdbf0fcefb6325aefd204cf6504cc37fd
Cr-Commit-Position: refs/heads/master@{#411654}

Powered by Google App Engine
This is Rietveld 408576698