Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(23)

Unified Diff: infra/bots/recipes/swarm_housekeeper.py

Issue 2237033002: Add extracting GM comments to the housekeeper bot. (Closed) Base URL: https://skia.googlesource.com/skia.git@master
Patch Set: reorder Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | infra/bots/recipes/swarm_housekeeper.expected/Housekeeper-PerCommit.json » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: infra/bots/recipes/swarm_housekeeper.py
diff --git a/infra/bots/recipes/swarm_housekeeper.py b/infra/bots/recipes/swarm_housekeeper.py
index ae31611b1e673454a705cc0950020c79c6e4332c..a849431c2d6946c8dc752b0b5ca143aae706a201 100644
--- a/infra/bots/recipes/swarm_housekeeper.py
+++ b/infra/bots/recipes/swarm_housekeeper.py
@@ -5,6 +5,7 @@
# Recipe for the Skia PerCommit Housekeeper.
+import os.path
rmistry 2016/08/12 15:14:39 Not used?
jcgregorio 2016/08/12 15:20:38 Fixed.
DEPS = [
'core',
@@ -68,6 +69,30 @@ def RunSteps(api):
cwd=cwd,
abort_on_failure=False)
+ env = {}
+ env['GOPATH'] = api.vars.tmp_dir.join('golib')
+ extractexe = env['GOPATH'].join('bin', 'extract_comments')
+ goexe = api.vars.slave_dir.join('go', 'go', 'bin', 'go')
rmistry 2016/08/12 15:14:39 So many 'go's here :)
jcgregorio 2016/08/12 15:20:38 Yeah, I think I could fiddle with the cipd packagi
+
+ # Compile extract_comments.
+ api.run(
+ api.step,
+ 'compile extract_comments',
+ cmd=[goexe, 'get', 'go.skia.org/infra/comments/go/extract_comments'],
+ cwd=cwd,
+ env=env,
+ abort_on_failure=True)
+
+ # Run extract_comments on the gm directory.
+ api.run(
+ api.step,
+ 'run extract_comments',
+ cmd=[extractexe, '--dir', 'gm', '--dest', 'gs://skia-doc/gm/comments.json'],
+ cwd=cwd,
+ env=env,
+ abort_on_failure=True)
+
+
def GenTests(api):
for mastername, slaves in TEST_BUILDERS.iteritems():
for slavename, builders_by_slave in slaves.iteritems():
« no previous file with comments | « no previous file | infra/bots/recipes/swarm_housekeeper.expected/Housekeeper-PerCommit.json » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698