Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(40)

Side by Side Diff: infra/bots/recipes/swarm_housekeeper.py

Issue 2237033002: Add extracting GM comments to the housekeeper bot. (Closed) Base URL: https://skia.googlesource.com/skia.git@master
Patch Set: unused import Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | infra/bots/recipes/swarm_housekeeper.expected/Housekeeper-PerCommit.json » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright 2014 The Chromium Authors. All rights reserved. 1 # Copyright 2014 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 5
6 # Recipe for the Skia PerCommit Housekeeper. 6 # Recipe for the Skia PerCommit Housekeeper.
7 7
8
9 DEPS = [ 8 DEPS = [
10 'core', 9 'core',
11 'recipe_engine/path', 10 'recipe_engine/path',
12 'recipe_engine/properties', 11 'recipe_engine/properties',
13 'recipe_engine/python', 12 'recipe_engine/python',
14 'recipe_engine/step', 13 'recipe_engine/step',
15 'run', 14 'run',
16 'vars', 15 'vars',
17 ] 16 ]
18 17
(...skipping 42 matching lines...) Expand 10 before | Expand all | Expand 10 after
61 '--gsutil_path', gsutil_path] 60 '--gsutil_path', gsutil_path]
62 if api.vars.is_trybot: 61 if api.vars.is_trybot:
63 cmd.extend(['--issue_number', str(api.properties['issue'])]) 62 cmd.extend(['--issue_number', str(api.properties['issue'])])
64 api.run( 63 api.run(
65 api.step, 64 api.step,
66 'generate and upload binary size data', 65 'generate and upload binary size data',
67 cmd=cmd, 66 cmd=cmd,
68 cwd=cwd, 67 cwd=cwd,
69 abort_on_failure=False) 68 abort_on_failure=False)
70 69
70 env = {}
71 env['GOPATH'] = api.vars.tmp_dir.join('golib')
72 extractexe = env['GOPATH'].join('bin', 'extract_comments')
73 goexe = api.vars.slave_dir.join('go', 'go', 'bin', 'go')
74
75 # Compile extract_comments.
76 api.run(
77 api.step,
78 'compile extract_comments',
79 cmd=[goexe, 'get', 'go.skia.org/infra/comments/go/extract_comments'],
80 cwd=cwd,
81 env=env,
82 abort_on_failure=True)
83
84 # Run extract_comments on the gm directory.
85 api.run(
86 api.step,
87 'run extract_comments',
88 cmd=[extractexe, '--dir', 'gm', '--dest', 'gs://skia-doc/gm/comments.json'],
89 cwd=cwd,
90 env=env,
91 abort_on_failure=True)
92
93
71 def GenTests(api): 94 def GenTests(api):
72 for mastername, slaves in TEST_BUILDERS.iteritems(): 95 for mastername, slaves in TEST_BUILDERS.iteritems():
73 for slavename, builders_by_slave in slaves.iteritems(): 96 for slavename, builders_by_slave in slaves.iteritems():
74 for buildername in builders_by_slave: 97 for buildername in builders_by_slave:
75 test = ( 98 test = (
76 api.test(buildername) + 99 api.test(buildername) +
77 api.properties(buildername=buildername, 100 api.properties(buildername=buildername,
78 mastername=mastername, 101 mastername=mastername,
79 slavename=slavename, 102 slavename=slavename,
80 buildnumber=5, 103 buildnumber=5,
81 revision='abc123', 104 revision='abc123',
82 path_config='kitchen', 105 path_config='kitchen',
83 swarm_out_dir='[SWARM_OUT_DIR]') + 106 swarm_out_dir='[SWARM_OUT_DIR]') +
84 api.path.exists(api.path['slave_build']) 107 api.path.exists(api.path['slave_build'])
85 ) 108 )
86 if 'Trybot' in buildername: 109 if 'Trybot' in buildername:
87 test.properties['issue'] = '500' 110 test.properties['issue'] = '500'
88 test.properties['patchset'] = '1' 111 test.properties['patchset'] = '1'
89 test.properties['rietveld'] = 'https://codereview.chromium.org' 112 test.properties['rietveld'] = 'https://codereview.chromium.org'
90 yield test 113 yield test
OLDNEW
« no previous file with comments | « no previous file | infra/bots/recipes/swarm_housekeeper.expected/Housekeeper-PerCommit.json » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698