Add extracting GM comments to the housekeeper bot.

infra/bots/recipes/swarm_housekeeper.py

 # Copyright 2014 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 
 # Recipe for the Skia PerCommit Housekeeper.
 
+import os.path

[rmistry, 2016/08/12 15:14:39]

Not used?

[jcgregorio, 2016/08/12 15:20:38]

Fixed.

 
 DEPS = [
   'core',
   'recipe_engine/path',
   'recipe_engine/properties',
   'recipe_engine/python',
   'recipe_engine/step',
   'run',
   'vars',
 ]
@@ skipping 43 matching lines @@
          '--gsutil_path', gsutil_path]
   if api.vars.is_trybot:
     cmd.extend(['--issue_number', str(api.properties['issue'])])
   api.run(
     api.step,
     'generate and upload binary size data',
     cmd=cmd,
     cwd=cwd,
     abort_on_failure=False)
 
+  env = {}
+  env['GOPATH'] = api.vars.tmp_dir.join('golib')
+  extractexe = env['GOPATH'].join('bin', 'extract_comments')
+  goexe = api.vars.slave_dir.join('go', 'go', 'bin', 'go')

[rmistry, 2016/08/12 15:14:39]

So many 'go's here :)

[jcgregorio, 2016/08/12 15:20:38]

Yeah, I think I could fiddle with the cipd packaging to remove one of them, but
not sure if it's worth it.

+
+  # Compile extract_comments.
+  api.run(
+    api.step,
+    'compile extract_comments',
+    cmd=[goexe, 'get', 'go.skia.org/infra/comments/go/extract_comments'],
+    cwd=cwd,
+    env=env,
+    abort_on_failure=True)
+
+  # Run extract_comments on the gm directory.
+  api.run(
+    api.step,
+    'run extract_comments',
+    cmd=[extractexe, '--dir', 'gm', '--dest', 'gs://skia-doc/gm/comments.json'],
+    cwd=cwd,
+    env=env,
+    abort_on_failure=True)
+
+
 def GenTests(api):
   for mastername, slaves in TEST_BUILDERS.iteritems():
     for slavename, builders_by_slave in slaves.iteritems():
       for buildername in builders_by_slave:
         test = (
           api.test(buildername) +
           api.properties(buildername=buildername,
                          mastername=mastername,
                          slavename=slavename,
                          buildnumber=5,
                          revision='abc123',
                          path_config='kitchen',
                          swarm_out_dir='[SWARM_OUT_DIR]') +
           api.path.exists(api.path['slave_build'])
         )
         if 'Trybot' in buildername:
           test.properties['issue'] = '500'
           test.properties['patchset'] = '1'
           test.properties['rietveld'] = 'https://codereview.chromium.org'
         yield test