Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(273)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2237033002: Add extracting GM comments to the housekeeper bot. (Closed)

Created:
4 years, 4 months ago by jcgregorio
Modified:
4 years, 4 months ago
Reviewers:
rmistry
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Add extracting GM comments to the housekeeper bot. BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2237033002 Committed: https://skia.googlesource.com/skia/+/106a9ff313f6b2dbf7bf9cf2ede37d2e98e7ecee

Patch Set 1 #

Patch Set 2 : fix dirs #

Patch Set 3 : tweak path so as not to pick up a locally installed Go. #

Patch Set 4 : fix go path #

Patch Set 5 : no other path #

Patch Set 6 : full path #

Patch Set 7 : debug #

Patch Set 8 : sleep #

Patch Set 9 : gopath #

Patch Set 10 : works #

Patch Set 11 : clean #

Patch Set 12 : clean #

Patch Set 13 : reorder #

Total comments: 4

Patch Set 14 : unused import #

Unified diffs Side-by-side diffs Delta from patch set Stats (+103 lines, -2 lines) Patch
M infra/bots/recipes/swarm_housekeeper.py View 1 2 3 4 5 6 7 8 9 10 11 12 13 2 chunks +24 lines, -1 line 0 comments Download
M infra/bots/recipes/swarm_housekeeper.expected/Housekeeper-PerCommit.json View 1 2 3 4 5 6 7 8 9 10 11 1 chunk +32 lines, -0 lines 0 comments Download
M infra/bots/recipes/swarm_housekeeper.expected/Housekeeper-PerCommit-Trybot.json View 1 2 3 4 5 6 7 8 9 10 11 1 chunk +32 lines, -0 lines 0 comments Download
M infra/bots/recipes/swarm_trigger.py View 1 chunk +3 lines, -1 line 0 comments Download
M infra/bots/recipes/swarm_trigger.expected/Housekeeper-PerCommit.json View 2 chunks +12 lines, -0 lines 0 comments Download

Messages

Total messages: 10 (5 generated)
jcgregorio
4 years, 4 months ago (2016-08-12 15:09:36 UTC) #3
rmistry
lgtm https://codereview.chromium.org/2237033002/diff/220001/infra/bots/recipes/swarm_housekeeper.py File infra/bots/recipes/swarm_housekeeper.py (right): https://codereview.chromium.org/2237033002/diff/220001/infra/bots/recipes/swarm_housekeeper.py#newcode8 infra/bots/recipes/swarm_housekeeper.py:8: import os.path Not used? https://codereview.chromium.org/2237033002/diff/220001/infra/bots/recipes/swarm_housekeeper.py#newcode75 infra/bots/recipes/swarm_housekeeper.py:75: goexe = ...
4 years, 4 months ago (2016-08-12 15:14:39 UTC) #4
jcgregorio
https://codereview.chromium.org/2237033002/diff/220001/infra/bots/recipes/swarm_housekeeper.py File infra/bots/recipes/swarm_housekeeper.py (right): https://codereview.chromium.org/2237033002/diff/220001/infra/bots/recipes/swarm_housekeeper.py#newcode8 infra/bots/recipes/swarm_housekeeper.py:8: import os.path On 2016/08/12 at 15:14:39, rmistry wrote: > ...
4 years, 4 months ago (2016-08-12 15:20:38 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2237033002/240001
4 years, 4 months ago (2016-08-12 15:24:33 UTC) #8
commit-bot: I haz the power
4 years, 4 months ago (2016-08-12 15:50:32 UTC) #10
Message was sent while issue was closed. 
Committed patchset #14 (id:240001) as
https://skia.googlesource.com/skia/+/106a9ff313f6b2dbf7bf9cf2ede37d2e98e7ecee

Powered by Google App Engine
This is Rietveld 408576698