Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(988)

Issue 2237023002: [MD User Menu] Adjusted the size and position of avatar button icon (Closed)

Created:
4 years, 4 months ago by Jane
Modified:
4 years, 4 months ago
Reviewers:
*groby-ooo-7-16, *sky
CC:
chromium-reviews, tfarina
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[MD User Menu] Adjusted the size and position of avatar button icon 1. Adjusted the size of the error icon in the avatar button to be 16 2. On mac, moved the icon from the RHS to LHS BUG=636037 Committed: https://crrev.com/19be3524dfeed25a8ef1e65fdd380f7a6ed1914f Cr-Commit-Position: refs/heads/master@{#411688}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -3 lines) Patch
M chrome/browser/ui/cocoa/profiles/avatar_button_controller.mm View 1 chunk +4 lines, -2 lines 0 comments Download
M chrome/browser/ui/views/profiles/new_avatar_button.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 10 (4 generated)
Jane
Thanks!
4 years, 4 months ago (2016-08-11 15:40:09 UTC) #3
sky
LGTM
4 years, 4 months ago (2016-08-11 20:25:57 UTC) #4
groby-ooo-7-16
lgtm
4 years, 4 months ago (2016-08-12 16:43:37 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2237023002/1
4 years, 4 months ago (2016-08-12 16:44:08 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 4 months ago (2016-08-12 17:25:15 UTC) #8
commit-bot: I haz the power
4 years, 4 months ago (2016-08-12 17:27:02 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/19be3524dfeed25a8ef1e65fdd380f7a6ed1914f
Cr-Commit-Position: refs/heads/master@{#411688}

Powered by Google App Engine
This is Rietveld 408576698