|
|
Chromium Code Reviews
Descriptionhi10p+LUT bugfix
BUG=622133
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel
Committed: https://crrev.com/26c4111e54e3f8c0636480ee7b309f588be13b94
Cr-Commit-Position: refs/heads/master@{#411903}
Patch Set 1 #
Messages
Total messages: 17 (8 generated)
Description was changed from ========== hi10p+LUT bugfix BUG=622133 ========== to ========== hi10p+LUT bugfix BUG=622133 CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel ==========
The CQ bit was checked by hubbe@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
hubbe@chromium.org changed reviewers: + danakj@chromium.org
Is there no pixel tests for this shader?
On 2016/08/12 23:25:25, danakj wrote: > Is there no pixel tests for this shader? The LUT code is behind a flag, and there are no tests that explicitly enable the flag yet.
On 2016/08/12 23:45:05, hubbe wrote: > On 2016/08/12 23:25:25, danakj wrote: > > Is there no pixel tests for this shader? > > The LUT code is behind a flag, and there are no tests that explicitly enable the > flag yet. Ah, time to add one yet?
On 2016/08/12 23:51:14, danakj wrote: > On 2016/08/12 23:45:05, hubbe wrote: > > On 2016/08/12 23:25:25, danakj wrote: > > > Is there no pixel tests for this shader? > > > > The LUT code is behind a flag, and there are no tests that explicitly enable > the > > flag yet. > > Ah, time to add one yet? Yes, plenty of time, but not today. :)
Well, rubberstamp LGTM then
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
The CQ bit was checked by hubbe@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Message was sent while issue was closed.
Committed patchset #1 (id:1)
Message was sent while issue was closed.
Description was changed from ========== hi10p+LUT bugfix BUG=622133 CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel ========== to ========== hi10p+LUT bugfix BUG=622133 CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel Committed: https://crrev.com/26c4111e54e3f8c0636480ee7b309f588be13b94 Cr-Commit-Position: refs/heads/master@{#411903} ==========
Message was sent while issue was closed.
Patchset 1 (id:??) landed as https://crrev.com/26c4111e54e3f8c0636480ee7b309f588be13b94 Cr-Commit-Position: refs/heads/master@{#411903} |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
