Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(392)

Issue 2237003006: Revert of [Downloads/Phone] Add button to icon row for offlining pages (Closed)

Created:
4 years, 4 months ago by gone
Modified:
4 years, 4 months ago
Reviewers:
Theresa
CC:
chromium-reviews, asanka, Dmitry Titov
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of [Downloads/Phone] Add button to icon row for offlining pages (patchset #2 id:20001 of https://codereview.chromium.org/2240263002/ ) Reason for revert: Lint errors. Original issue's description: > [Downloads/Phone] Add button to icon row for offlining pages > > * Generalizes the AppMenu[Adapter/PropertiesDelegate] code to support > up to five items. > > * Adds an icon to the phone/compressed tablet menu that is for > offlining a page. > > * Hides it behind a flag called: --enable-offline-page-downloading > > * Removes an unused icon. > > - Not hooked up to anything yet. > > - The icon is off-center because the asset provided by go/icons is > off-center. Waiting for a new one from UX. > > BUG=616324 > > Committed: https://crrev.com/ca8c5868dbd7ea6734cb80938618ab6870d96ba3 > Cr-Commit-Position: refs/heads/master@{#411736} TBR=twellington@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=616324 Committed: https://crrev.com/c0422f141f470ae3d02ed7a43f0e594fb8126a97 Cr-Commit-Position: refs/heads/master@{#411757}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+139 lines, -149 lines) Patch
A chrome/android/java/res/drawable-hdpi/bookmark_filter_offline_pages.png View Binary file 0 comments Download
A chrome/android/java/res/drawable-mdpi/bookmark_filter_offline_pages.png View Binary file 0 comments Download
A chrome/android/java/res/drawable-xhdpi/bookmark_filter_offline_pages.png View Binary file 0 comments Download
A chrome/android/java/res/drawable-xxhdpi/bookmark_filter_offline_pages.png View Binary file 0 comments Download
A chrome/android/java/res/drawable-xxxhdpi/bookmark_filter_offline_pages.png View Binary file 0 comments Download
A chrome/android/java/res/layout/four_button_menu_item.xml View 1 chunk +44 lines, -0 lines 0 comments Download
D chrome/android/java/res/layout/icon_row_menu_item.xml View 1 chunk +0 lines, -32 lines 0 comments Download
A chrome/android/java/res/layout/three_button_menu_item.xml View 1 chunk +36 lines, -0 lines 0 comments Download
M chrome/android/java/res/menu/main_menu.xml View 1 chunk +0 lines, -3 lines 0 comments Download
M chrome/android/java/res/values-v17/styles.xml View 1 chunk +0 lines, -7 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/ChromeActivity.java View 1 chunk +0 lines, -2 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/ChromeSwitches.java View 1 chunk +0 lines, -6 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/appmenu/AppMenuAdapter.java View 8 chunks +57 lines, -77 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/appmenu/AppMenuPropertiesDelegate.java View 2 chunks +0 lines, -20 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/download/ui/FilterAdapter.java View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
gone
Created Revert of [Downloads/Phone] Add button to icon row for offlining pages
4 years, 4 months ago (2016-08-12 20:29:25 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2237003006/1
4 years, 4 months ago (2016-08-12 20:29:55 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 4 months ago (2016-08-12 20:31:03 UTC) #4
commit-bot: I haz the power
4 years, 4 months ago (2016-08-12 20:34:31 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/c0422f141f470ae3d02ed7a43f0e594fb8126a97
Cr-Commit-Position: refs/heads/master@{#411757}

Powered by Google App Engine
This is Rietveld 408576698