Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(139)

Issue 2236993002: Do not call check-webkit-style with empty affected file list as it tries to check all edited files … (Closed)

Created:
4 years, 4 months ago by Gleb Lanbin
Modified:
4 years, 3 months ago
Reviewers:
cbiesinger, Dirk Pranke, eae
CC:
chromium-reviews, szager+layoutwatch_chromium.org, zoltan1, blink-reviews-layout_chromium.org, pdr+renderingwatchlist_chromium.org, eae+blinkwatch, leviw+renderwatch, jchaffraix+rendering, blink-reviews, ikilpatrick, eae
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Do not call check-webkit-style with empty affected file list as it tries to check all edited files including the skipped ones This patch changes _CheckStyle to prevent calling check-webkit-style with empty arguments list if all files got filtered out. BUG=635619 TEST=third_party/WebKit/PRESUBMIT_test.py Committed: https://crrev.com/e6e1b27c1004a687eb183822f912c25693414a40 Cr-Commit-Position: refs/heads/master@{#414472}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+79 lines, -5 lines) Patch
M third_party/WebKit/PRESUBMIT.py View 1 chunk +10 lines, -5 lines 0 comments Download
A third_party/WebKit/PRESUBMIT_test.py View 1 chunk +69 lines, -0 lines 0 comments Download

Messages

Total messages: 23 (13 generated)
Gleb Lanbin
4 years, 4 months ago (2016-08-11 14:58:35 UTC) #4
Gleb Lanbin
4 years, 4 months ago (2016-08-11 14:59:50 UTC) #6
eae
Looks reasonable to me.
4 years, 4 months ago (2016-08-11 14:59:58 UTC) #8
Gleb Lanbin
4 years, 4 months ago (2016-08-11 15:02:14 UTC) #10
eae
LGTM
4 years, 4 months ago (2016-08-12 15:47:57 UTC) #16
cbiesinger
Ping?
4 years, 4 months ago (2016-08-22 23:00:02 UTC) #17
Dirk Pranke
lgtm. Sorry for the delay, this must've fallen off my radar.
4 years, 4 months ago (2016-08-22 23:06:46 UTC) #18
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2236993002/40001
4 years, 3 months ago (2016-08-25 16:18:27 UTC) #20
commit-bot: I haz the power
Committed patchset #1 (id:40001)
4 years, 3 months ago (2016-08-25 18:08:53 UTC) #21
commit-bot: I haz the power
4 years, 3 months ago (2016-08-25 18:12:27 UTC) #23
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/e6e1b27c1004a687eb183822f912c25693414a40
Cr-Commit-Position: refs/heads/master@{#414472}

Powered by Google App Engine
This is Rietveld 408576698