Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(8)

Issue 2236953002: Improvements to build_command_buffer.py (Closed)

Created:
4 years, 4 months ago by bsalomon
Modified:
4 years, 4 months ago
Reviewers:
robertphillips
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Improvements to build_command_buffer.py Allows a shortcut, -t, for --chrome-build-type and clarifies meaning of the value in help. Removes --fetch. This used to work with gyp builds but since it doesn't run gn it currently fails to build after fetching the src. Also, it wasn't being used. Adds --no-hooks. Like --no-sync it but also doesn't run gclient runhooks. GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2236953002 Committed: https://skia.googlesource.com/skia/+/90b5cc31f373e831c942bfd3113b44486546846b

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -31 lines) Patch
M tools/build_command_buffer.py View 4 chunks +18 lines, -31 lines 0 comments Download

Messages

Total messages: 9 (5 generated)
bsalomon
Some minor improvements to make this script easier to use when you've already synced everything ...
4 years, 4 months ago (2016-08-11 13:24:13 UTC) #4
robertphillips
lgtm as far as understand what's going on
4 years, 4 months ago (2016-08-11 14:35:36 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2236953002/1
4 years, 4 months ago (2016-08-11 15:01:08 UTC) #7
commit-bot: I haz the power
4 years, 4 months ago (2016-08-11 15:25:43 UTC) #9
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/90b5cc31f373e831c942bfd3113b44486546846b

Powered by Google App Engine
This is Rietveld 408576698