Ignore gpu blacklists with kOverrideUseGLWithOSMesaForTests.

Ignore gpu blacklists with kOverrideUseGLWithOSMesaForTests.

BUG=none

Committed: https://crrev.com/965c20a1c6a93354a632e3178374efc02d2a7a18
Cr-Commit-Position: refs/heads/master@{#412162}

[sadrul, 2016-08-13 02:05:43]

The CQ bit was checked by sadrul@chromium.org to run a CQ dry run

[sadrul, 2016-08-13 02:06:08]

sadrul@chromium.org changed reviewers:
+ danakj@chromium.org

[commit-bot: I haz the power, 2016-08-13 02:06:08]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[danakj, 2016-08-13 02:14:57]

danakj@chromium.org changed reviewers:
+ jbauman@chromium.org

[danakj, 2016-08-13 02:14:57]

+jbauman

https://codereview.chromium.org/2236933008/diff/1/content/browser/gpu/gpu_dat...
File content/browser/gpu/gpu_data_manager_impl_private.cc (right):

https://codereview.chromium.org/2236933008/diff/1/content/browser/gpu/gpu_dat...
content/browser/gpu/gpu_data_manager_impl_private.cc:528: gpu_info.gpu.vendor_id
= 0xffff;
Do these not work? Do you get why?

[commit-bot: I haz the power, 2016-08-13 02:52:14]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-13 02:52:15]

Dry run: This issue passed the CQ dry run.

[sadrul, 2016-08-13 02:58:45]

https://codereview.chromium.org/2236933008/diff/1/content/browser/gpu/gpu_dat...
File content/browser/gpu/gpu_data_manager_impl_private.cc (right):

https://codereview.chromium.org/2236933008/diff/1/content/browser/gpu/gpu_dat...
content/browser/gpu/gpu_data_manager_impl_private.cc:528: gpu_info.gpu.vendor_id
= 0xffff;
On 2016/08/13 02:14:57, danakj wrote:
> Do these not work? Do you get why?

Because of this entry in the gpu blacklist:
https://cs.chromium.org/chromium/src/gpu/config/software_rendering_list_json....

[sadrul, 2016-08-15 16:25:26]

On 2016/08/13 02:58:45, sadrul wrote:
>
https://codereview.chromium.org/2236933008/diff/1/content/browser/gpu/gpu_dat...
> File content/browser/gpu/gpu_data_manager_impl_private.cc (right):
> 
>
https://codereview.chromium.org/2236933008/diff/1/content/browser/gpu/gpu_dat...
> content/browser/gpu/gpu_data_manager_impl_private.cc:528:
gpu_info.gpu.vendor_id
> = 0xffff;
> On 2016/08/13 02:14:57, danakj wrote:
> > Do these not work? Do you get why?
> 
> Because of this entry in the gpu blacklist:
>
https://cs.chromium.org/chromium/src/gpu/config/software_rendering_list_json....

Another option is to add some exception in the rule for device_id=0xffff and
vendor_id=0xffff, but I think that wouldn't a good idea since we may need to add
that exception to a number of entries (potentially all)?

[danakj, 2016-08-15 19:42:19]

On 2016/08/13 02:58:45, sadrul wrote:
>
https://codereview.chromium.org/2236933008/diff/1/content/browser/gpu/gpu_dat...
> File content/browser/gpu/gpu_data_manager_impl_private.cc (right):
> 
>
https://codereview.chromium.org/2236933008/diff/1/content/browser/gpu/gpu_dat...
> content/browser/gpu/gpu_data_manager_impl_private.cc:528:
gpu_info.gpu.vendor_id
> = 0xffff;
> On 2016/08/13 02:14:57, danakj wrote:
> > Do these not work? Do you get why?
> 
> Because of this entry in the gpu blacklist:
>
https://cs.chromium.org/chromium/src/gpu/config/software_rendering_list_json....

Hmm, doesn't that just disable webgl?

[danakj, 2016-08-15 19:42:32]

On 2016/08/15 19:42:19, danakj wrote:
> On 2016/08/13 02:58:45, sadrul wrote:
> >
>
https://codereview.chromium.org/2236933008/diff/1/content/browser/gpu/gpu_dat...
> > File content/browser/gpu/gpu_data_manager_impl_private.cc (right):
> > 
> >
>
https://codereview.chromium.org/2236933008/diff/1/content/browser/gpu/gpu_dat...
> > content/browser/gpu/gpu_data_manager_impl_private.cc:528:
> gpu_info.gpu.vendor_id
> > = 0xffff;
> > On 2016/08/13 02:14:57, danakj wrote:
> > > Do these not work? Do you get why?
> > 
> > Because of this entry in the gpu blacklist:
> >
>
https://cs.chromium.org/chromium/src/gpu/config/software_rendering_list_json....
> 
> Hmm, doesn't that just disable webgl?

Oh nvm I see.

[danakj, 2016-08-15 19:43:09]

LGTM

[sadrul, 2016-08-16 02:31:53]

sadrul@chromium.org changed reviewers:
+ piman@chromium.org

[sadrul, 2016-08-16 02:31:54]

+piman@ for alternate content/browser/gpu owner

[jbauman, 2016-08-16 02:55:43]

lgtm

[sadrul, 2016-08-16 03:12:41]

The CQ bit was checked by sadrul@chromium.org

[commit-bot: I haz the power, 2016-08-16 03:13:07]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-16 04:02:14]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-08-16 04:03:39]

Description was changed from

==========
Ignore gpu blacklists with kOverrideUseGLWithOSMesaForTests.

BUG=none
==========

to

==========
Ignore gpu blacklists with kOverrideUseGLWithOSMesaForTests.

BUG=none

Committed: https://crrev.com/965c20a1c6a93354a632e3178374efc02d2a7a18
Cr-Commit-Position: refs/heads/master@{#412162}
==========

[commit-bot: I haz the power, 2016-08-16 04:03:40]

Patchset 1 (id:??) landed as
https://crrev.com/965c20a1c6a93354a632e3178374efc02d2a7a18
Cr-Commit-Position: refs/heads/master@{#412162}