OOPIF: Reinitialize a dead subframe correctly for same-site navigations.

OOPIF: Reinitialize a dead subframe correctly for same-site navigations.

Currently, if a subframe renderer dies, the subframe cannot be
re-navigated to the same site, because the corresponding code path in
RenderFrameHostManager::Navigate() uses InitRenderView which only
revives top-level RenderFrames.  This CL adds support to also revive
subframe RenderFrames.  Since PlzNavigate also relied on this logic,
duplicating it in GetFrameHostForNavigation, the new logic is
extracted into a common helper.

BUG=634368
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation

Committed: https://crrev.com/c15fab9e2bbeeb86d3188db4c4eac85dccd1d8d9
Cr-Commit-Position: refs/heads/master@{#411479}

[alexmos, 2016-08-10 23:43:46]

Description was changed from

==========
OOPIF: Reinitialize a dead subframe correctly for same-site navigations.

Currently, if a subframe renderer dies, the subframe cannot be
re-navigated to the same site, because the corresponding code path in
RenderFrameHostManager::Navigate() uses InitRenderView which only
revives top-level RenderFrames.  This CL adds support to also revive
subframe RenderFrames.  Since PlzNavigate also relied on this logic,
duplicating it in GetFrameHostForNavigation, the new logic is
extracted into a common helper.

BUG=634368
==========

to

==========
OOPIF: Reinitialize a dead subframe correctly for same-site navigations.

Currently, if a subframe renderer dies, the subframe cannot be
re-navigated to the same site, because the corresponding code path in
RenderFrameHostManager::Navigate() uses InitRenderView which only
revives top-level RenderFrames.  This CL adds support to also revive
subframe RenderFrames.  Since PlzNavigate also relied on this logic,
duplicating it in GetFrameHostForNavigation, the new logic is
extracted into a common helper.

BUG=634368
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation
==========

[alexmos, 2016-08-10 23:44:12]

The CQ bit was checked by alexmos@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-10 23:45:14]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-11 00:56:10]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-11 00:56:11]

Dry run: Try jobs failed on following builders:
  win_chromium_x64_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...)

[alexmos, 2016-08-11 01:07:31]

alexmos@chromium.org changed reviewers:
+ creis@chromium.org

[alexmos, 2016-08-11 01:07:31]

Charlie, can you please take a look at whether this makes sense?

https://codereview.chromium.org/2236753002/diff/1/content/browser/frame_host/...
File content/browser/frame_host/render_frame_host_manager.cc (right):

https://codereview.chromium.org/2236753002/diff/1/content/browser/frame_host/...
content/browser/frame_host/render_frame_host_manager.cc:2039: if
(!InitRenderView(render_frame_host->render_view_host(), nullptr))
I was thinking whether passing a nullptr proxy is always correct here, and I
think it is - for one, UpdateStateForNavigate would've cleared the proxy before
we get here.

https://codereview.chromium.org/2236753002/diff/1/content/browser/frame_host/...
content/browser/frame_host/render_frame_host_manager.cc:2050:
GetProxyToParent()->SetChildRWHView(render_frame_host->GetView());
Normally, this is done as part of CommitPending().  However, for same-site
navigations CommitPending won't happen, since the current RFH will be reused.  

The RWHVCF is cleared in the CPFC when the process dies in
RWHVCF::RenderProcessGone -> RWHVCF::Destroy.

[Charlie Reis, 2016-08-11 18:50:30]

Thanks for tracking this down!  LGTM.

https://codereview.chromium.org/2236753002/diff/1/content/browser/frame_host/...
File content/browser/frame_host/render_frame_host_manager.cc (right):

https://codereview.chromium.org/2236753002/diff/1/content/browser/frame_host/...
content/browser/frame_host/render_frame_host_manager.cc:2039: if
(!InitRenderView(render_frame_host->render_view_host(), nullptr))
On 2016/08/11 01:07:31, alexmos wrote:
> I was thinking whether passing a nullptr proxy is always correct here, and I
> think it is - for one, UpdateStateForNavigate would've cleared the proxy
before
> we get here.

Acknowledged.

https://codereview.chromium.org/2236753002/diff/1/content/browser/frame_host/...
content/browser/frame_host/render_frame_host_manager.cc:2050:
GetProxyToParent()->SetChildRWHView(render_frame_host->GetView());
On 2016/08/11 01:07:31, alexmos wrote:
> Normally, this is done as part of CommitPending().  However, for same-site
> navigations CommitPending won't happen, since the current RFH will be reused. 

> 
> The RWHVCF is cleared in the CPFC when the process dies in
> RWHVCF::RenderProcessGone -> RWHVCF::Destroy.

Acknowledged.

https://codereview.chromium.org/2236753002/diff/1/content/browser/site_per_pr...
File content/browser/site_per_process_browsertest.cc (right):

https://codereview.chromium.org/2236753002/diff/1/content/browser/site_per_pr...
content/browser/site_per_process_browsertest.cc:7765: // Test the a crashed
subframe can be successfully navigated to the site it was
nit: s/the/that/

[alexmos, 2016-08-11 20:45:48]

Thanks!

https://codereview.chromium.org/2236753002/diff/1/content/browser/site_per_pr...
File content/browser/site_per_process_browsertest.cc (right):

https://codereview.chromium.org/2236753002/diff/1/content/browser/site_per_pr...
content/browser/site_per_process_browsertest.cc:7765: // Test the a crashed
subframe can be successfully navigated to the site it was
On 2016/08/11 18:50:29, Charlie Reis wrote:
> nit: s/the/that/

Done.

[alexmos, 2016-08-11 20:45:54]

The CQ bit was checked by alexmos@chromium.org

[alexmos, 2016-08-11 20:45:54]

The patchset sent to the CQ was uploaded after l-g-t-m from creis@chromium.org
Link to the patchset: https://codereview.chromium.org/2236753002/#ps20001
(title: "Fix Charlie's nit")

[commit-bot: I haz the power, 2016-08-11 20:46:25]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-11 22:06:11]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-11 22:06:13]

Try jobs failed on following builders:
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[alexmos, 2016-08-11 23:28:43]

The CQ bit was checked by alexmos@chromium.org

[commit-bot: I haz the power, 2016-08-11 23:29:39]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-12 00:30:57]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-08-12 00:33:01]

Description was changed from

==========
OOPIF: Reinitialize a dead subframe correctly for same-site navigations.

Currently, if a subframe renderer dies, the subframe cannot be
re-navigated to the same site, because the corresponding code path in
RenderFrameHostManager::Navigate() uses InitRenderView which only
revives top-level RenderFrames.  This CL adds support to also revive
subframe RenderFrames.  Since PlzNavigate also relied on this logic,
duplicating it in GetFrameHostForNavigation, the new logic is
extracted into a common helper.

BUG=634368
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation
==========

to

==========
OOPIF: Reinitialize a dead subframe correctly for same-site navigations.

Currently, if a subframe renderer dies, the subframe cannot be
re-navigated to the same site, because the corresponding code path in
RenderFrameHostManager::Navigate() uses InitRenderView which only
revives top-level RenderFrames.  This CL adds support to also revive
subframe RenderFrames.  Since PlzNavigate also relied on this logic,
duplicating it in GetFrameHostForNavigation, the new logic is
extracted into a common helper.

BUG=634368
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation

Committed: https://crrev.com/c15fab9e2bbeeb86d3188db4c4eac85dccd1d8d9
Cr-Commit-Position: refs/heads/master@{#411479}
==========

[commit-bot: I haz the power, 2016-08-12 00:33:02]

Patchset 2 (id:??) landed as
https://crrev.com/c15fab9e2bbeeb86d3188db4c4eac85dccd1d8d9
Cr-Commit-Position: refs/heads/master@{#411479}