DevTools: Override browser commit hash with process.env.CHROMIUM_COMMIT

third_party/WebKit/Source/devtools/scripts/hosted_mode/server.js

 // Copyright (c) 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 var fs = require("fs");
 var http = require("http");
 var https = require("https");
 var path = require("path");
 var parseURL = require("url").parse;
 var Stream = require("stream").Transform;
 
@@ skipping 24 matching lines @@
     function handleProxyError(err)
     {
         console.log(`Error fetching over the internet file ${filePath}:`, err);
         console.log(`Make sure you opened Chrome with the flag "--remote-debugging-port=${remoteDebuggingPort}"`);
         sendResponse(500, "500 - Internal Server Error");
     }
 
     var absoluteFilePath = path.join(process.cwd(), filePath);
     if (!path.resolve(absoluteFilePath).startsWith(devtoolsFolder)) {
         console.log(`File requested is outside of devtools folder: ${devtoolsFolder}`);
-        sendResponse(403, "`403 - Access denied. File requested is outside of devtools folder: ${devtoolsFolder}`");

[chenwilliam, 2016/08/10 22:04:55]

The surrounding double quotes were causing the placeholder to not evaluate.

+        sendResponse(403, `403 - Access denied. File requested is outside of devtools folder: ${devtoolsFolder}`);
         return;
     }
 
     fs.exists(absoluteFilePath, fsExistsCallback);
 
     function fsExistsCallback(fileExists)
     {
         if (!fileExists) {
             console.log(`Cannot find file ${absoluteFilePath}`);
             sendResponse(404, "404 - File not found");
@@ skipping 30 matching lines @@
 {
     return `https://chrome-devtools-frontend.appspot.com/serve_file/@${commitHash}/${path}`;
 }
 
 var proxyFileCache = new Map();
 
 function proxy(filePath)
 {
     if (!(filePath in proxyFilePathToURL))
         return null;
+    if (process.env.CHROMIUM_COMMIT)
+        return onProxyFileURL(proxyFilePathToURL[filePath](process.env.CHROMIUM_COMMIT));
     return fetch(`http://localhost:${remoteDebuggingPort}/json/version`)
-        .then(onBrowserMetadata);
+        .then(onBrowserMetadata)
+        .then(onProxyFileURL);
 
     function onBrowserMetadata(metadata)
     {
         var metadataObject = JSON.parse(metadata);
         var match = metadataObject["WebKit-Version"].match(/\s\(@(\b[0-9a-f]{5,40}\b)/);
         var commitHash = match[1];
         var proxyFileURL = proxyFilePathToURL[filePath](commitHash);
+        return proxyFileURL;
+    }
+
+    function onProxyFileURL(proxyFileURL)
+    {
         if (proxyFileCache.has(proxyFileURL))
-            return proxyFileCache.get(proxyFileURL);
+            return Promise.resolve(proxyFileCache.get(proxyFileURL));
         return fetch(proxyFileURL)
             .then(cacheProxyFile.bind(null, proxyFileURL));
     }
 
     function cacheProxyFile(proxyFileURL, data)
     {
         proxyFileCache.set(proxyFileURL, data);
         return data;
     }
 }
@@ skipping 23 matching lines @@
         if (response.statusCode !== 200) {
             reject(new Error(`Request error: + ${response.statusCode}`));
             return;
         }
         var body = new Stream();
         response.on("data", chunk => body.push(chunk));
         response.on("end", () => resolve(body.read()));
     }
 }