DevTools: Override browser commit hash with process.env.CHROMIUM_COMMIT

DevTools: Override browser commit hash with process.env.CHROMIUM_COMMIT

This is a simple solution for hosted mode users who want to override which
version of the proxied files (SupportedCSSProperties.js and InspectorBackendCommands.js)
they want to use, instead of relying on the default which gets the commit hash
of the browser/back-end.

Example:
CHROMIUM_COMMIT=813208daf9e9821657e55ef7c40a14815efdcf49 npm run server

Will update docs after this lands.

Added a comment to the bug issue for more context on why we used this approach.

BUG=635136
Committed: https://crrev.com/846251ff8e503e1a90ce93a5119d32010e8c872f
Cr-Commit-Position: refs/heads/master@{#411721}

[chenwilliam, 2016-08-10 22:02:26]

Description was changed from

==========
DevTools: Override browser commit hash with process.env.CHROMIUM_COMMIT

DevTools: Override browser commit hash with process.env.CHROMIUM_COMMIT

This is a simple solution for hosted mode users who want to override which
version of the proxied files (SupportedCSSProperties.js and
InspectorBackendCommands.js)
they want to use, instead of relying on the default which gets the commit hash
of the browser/back-end.

Example:
CHROMIUM_COMMIT=813208daf9e9821657e55ef7c40a14815efdcf49 npm run server

Will update docs after this lands.

Added a comment to the bug issue for more context on why we used this approach.

BUG=635136
==========

to

==========
DevTools: Override browser commit hash with process.env.CHROMIUM_COMMIT

This is a simple solution for hosted mode users who want to override which
version of the proxied files (SupportedCSSProperties.js and
InspectorBackendCommands.js)
they want to use, instead of relying on the default which gets the commit hash
of the browser/back-end.

Example:
CHROMIUM_COMMIT=813208daf9e9821657e55ef7c40a14815efdcf49 npm run server

Will update docs after this lands.

Added a comment to the bug issue for more context on why we used this approach.

BUG=635136
==========

[chenwilliam, 2016-08-10 22:04:55]

chenwilliam@chromium.org changed reviewers:
+ lushnikov@chromium.org, paulirish@chromium.org

[chenwilliam, 2016-08-10 22:04:56]

https://codereview.chromium.org/2236733002/diff/1/third_party/WebKit/Source/d...
File third_party/WebKit/Source/devtools/scripts/hosted_mode/server.js (left):

https://codereview.chromium.org/2236733002/diff/1/third_party/WebKit/Source/d...
third_party/WebKit/Source/devtools/scripts/hosted_mode/server.js:45:
sendResponse(403, "`403 - Access denied. File requested is outside of devtools
folder: ${devtoolsFolder}`");
The surrounding double quotes were causing the placeholder to not evaluate.

[lushnikov, 2016-08-10 23:29:11]

lgtm

let's add a "--help" to the script which would describe it's api

[chenwilliam, 2016-08-12 17:31:35]

On 2016/08/10 23:29:11, lushnikov wrote:
> lgtm
> 
> let's add a "--help" to the script which would describe it's api

I tried adding the "--help" to the script so users could run something like:
"npm run server --help"

However, npm uses it for their own help info, and it never actually executes our
node.js script.

You can pass flags to the node script using this syntax:
"npm run server -- --help"

It's pretty clunky, so I just included a helpful snippet with a link to the
contributing doc 
whenever you start the server.

Example:
"Started hosted mode server at http://localhost:8090

For info on using the hosted mode server, see our contributing docs:
https://bit.ly/devtools-contribution-guide
Tip: Look for the 'Hosted Mode Server Options' section"

[chenwilliam, 2016-08-12 17:31:42]

The CQ bit was checked by chenwilliam@chromium.org

[chenwilliam, 2016-08-12 17:31:43]

The patchset sent to the CQ was uploaded after l-g-t-m from
lushnikov@chromium.org
Link to the patchset: https://codereview.chromium.org/2236733002/#ps20001
(title: "added helpful info")

[commit-bot: I haz the power, 2016-08-12 17:32:07]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-12 18:47:30]

Description was changed from

==========
DevTools: Override browser commit hash with process.env.CHROMIUM_COMMIT

This is a simple solution for hosted mode users who want to override which
version of the proxied files (SupportedCSSProperties.js and
InspectorBackendCommands.js)
they want to use, instead of relying on the default which gets the commit hash
of the browser/back-end.

Example:
CHROMIUM_COMMIT=813208daf9e9821657e55ef7c40a14815efdcf49 npm run server

Will update docs after this lands.

Added a comment to the bug issue for more context on why we used this approach.

BUG=635136
==========

to

==========
DevTools: Override browser commit hash with process.env.CHROMIUM_COMMIT

This is a simple solution for hosted mode users who want to override which
version of the proxied files (SupportedCSSProperties.js and
InspectorBackendCommands.js)
they want to use, instead of relying on the default which gets the commit hash
of the browser/back-end.

Example:
CHROMIUM_COMMIT=813208daf9e9821657e55ef7c40a14815efdcf49 npm run server

Will update docs after this lands.

Added a comment to the bug issue for more context on why we used this approach.

BUG=635136
==========

[commit-bot: I haz the power, 2016-08-12 18:47:31]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-08-12 18:49:34]

Description was changed from

==========
DevTools: Override browser commit hash with process.env.CHROMIUM_COMMIT

This is a simple solution for hosted mode users who want to override which
version of the proxied files (SupportedCSSProperties.js and
InspectorBackendCommands.js)
they want to use, instead of relying on the default which gets the commit hash
of the browser/back-end.

Example:
CHROMIUM_COMMIT=813208daf9e9821657e55ef7c40a14815efdcf49 npm run server

Will update docs after this lands.

Added a comment to the bug issue for more context on why we used this approach.

BUG=635136
==========

to

==========
DevTools: Override browser commit hash with process.env.CHROMIUM_COMMIT

This is a simple solution for hosted mode users who want to override which
version of the proxied files (SupportedCSSProperties.js and
InspectorBackendCommands.js)
they want to use, instead of relying on the default which gets the commit hash
of the browser/back-end.

Example:
CHROMIUM_COMMIT=813208daf9e9821657e55ef7c40a14815efdcf49 npm run server

Will update docs after this lands.

Added a comment to the bug issue for more context on why we used this approach.

BUG=635136

Committed: https://crrev.com/846251ff8e503e1a90ce93a5119d32010e8c872f
Cr-Commit-Position: refs/heads/master@{#411721}
==========

[commit-bot: I haz the power, 2016-08-12 18:49:35]

Patchset 2 (id:??) landed as
https://crrev.com/846251ff8e503e1a90ce93a5119d32010e8c872f
Cr-Commit-Position: refs/heads/master@{#411721}

[chenwilliam, 2016-08-12 19:08:09]

On 2016/08/12 18:49:35, commit-bot: I haz the power wrote:
> Patchset 2 (id:??) landed as
> https://crrev.com/846251ff8e503e1a90ce93a5119d32010e8c872f
> Cr-Commit-Position: refs/heads/master@{#411721}

Updated docs (bit.ly/devtools-contribution-guide) using suggestions.
Paul, ptal.