Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(549)

Unified Diff: Source/core/css/parser/CSSPropertyParser.cpp

Issue 223673008: [CSS Shapes] CRASH with calc() value args in inset round (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Created 6 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « LayoutTests/fast/shapes/shape-outside-floats/shape-outside-inset-round-calc-crash-expected.txt ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/core/css/parser/CSSPropertyParser.cpp
diff --git a/Source/core/css/parser/CSSPropertyParser.cpp b/Source/core/css/parser/CSSPropertyParser.cpp
index 8a1a6428c0099c4056ac1fe5ad1c26c682dcacfe..94d422a18e6f13550844a5e7674d558a295fc74c 100644
--- a/Source/core/css/parser/CSSPropertyParser.cpp
+++ b/Source/core/css/parser/CSSPropertyParser.cpp
@@ -4023,9 +4023,9 @@ PassRefPtrWillBeRawPtr<CSSBasicShape> CSSPropertyParser::parseInsetRoundedCorner
if (!argument)
return nullptr;
- CSSParserValueList radiusArguments;
+ Vector<CSSParserValue*> radiusArguments;
while (argument) {
- radiusArguments.addValue(*argument);
+ radiusArguments.append(argument);
argument = args->next();
}
@@ -4042,7 +4042,7 @@ PassRefPtrWillBeRawPtr<CSSBasicShape> CSSPropertyParser::parseInsetRoundedCorner
unsigned indexAfterSlash = 0;
for (unsigned i = 0; i < num; ++i) {
- CSSParserValue* value = radiusArguments.valueAt(i);
+ CSSParserValue* value = radiusArguments.at(i);
if (value->unit == CSSParserValue::Operator) {
if (value->iValue != '/')
return nullptr;
« no previous file with comments | « LayoutTests/fast/shapes/shape-outside-floats/shape-outside-inset-round-calc-crash-expected.txt ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698