content/browser/renderer_host/input/web_input_event_util.cc - Issue 223673006: Support GestureBegin and GestureEnd in ui::GestureProvider

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/renderer_host/input/web_input_event_util.cc

Issue 223673006: Support GestureBegin and GestureEnd in ui::GestureProvider (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Address jdduke's comments. Created 6 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: content/browser/renderer_host/input/web_input_event_util.cc

diff --git a/content/browser/renderer_host/input/web_input_event_util.cc b/content/browser/renderer_host/input/web_input_event_util.cc

index 75e762cce9bbe95df1463fc90d8be588c19250e6..37a0d60e7c29b0b048529df978ececb33bf2b111 100644

--- a/content/browser/renderer_host/input/web_input_event_util.cc

+++ b/content/browser/renderer_host/input/web_input_event_util.cc

@@ -331,6 +331,11 @@ WebGestureEvent CreateWebGestureEventFromGestureEventData(

gesture.data.tapDown.height =

data.details.bounding_box_f().height() * scale;

break;

+ case ui::ET_GESTURE_BEGIN:

+ case ui::ET_GESTURE_END:

+ NOTREACHED() << "ET_GESTURE_BEGIN and ET_GESTURE_END are only produced "

+ << "in Aura, and should never end up here.";

+ break;

default:

NOTREACHED() << "ui::EventType provided wasn't a valid gesture event.";

break;