chrome/browser/resources/settings/settings_main/settings_main.html - Issue 2236723002: MD Settings: Hide the advanced page toggle control during searching.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/resources/settings/settings_main/settings_main.html

Issue 2236723002: MD Settings: Hide the advanced page toggle control during searching. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Address comments. Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/resources/settings/settings_main/settings_main.html

diff --git a/chrome/browser/resources/settings/settings_main/settings_main.html b/chrome/browser/resources/settings/settings_main/settings_main.html

index 0eb24b26c508c22abe88a638926c630b99e1e782..53be671584def729a0cb68442b4444f59e6445ea 100644

--- a/chrome/browser/resources/settings/settings_main/settings_main.html

+++ b/chrome/browser/resources/settings/settings_main/settings_main.html

@@ -64,10 +64,10 @@

</template>

<template is="dom-if"

if="[[showAdvancedSettings_(pageVisibility.advancedSettings)]]">

- <template is="dom-if"

- if="[[showAdvancedToggle_(showPages_.basic, inSubpage_)]]">

+ <template is="dom-if" if="[[showAdvancedToggle_(

+ showPages_.basic, inSubpage_, previousShowPages_)]]">

- <div id="toggleContainer" hidden$="[[showNoResultsFound_]]">

+ <div id="toggleContainer">

<span>$i18n{advancedPageTitle}</span>

<iron-icon icon="[[arrowState_(showPages_.advanced)]]"></iron-icon>

« no previous file with comments | « no previous file | chrome/browser/resources/settings/settings_main/settings_main.js » ('j') | no next file with comments »