Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(81)

Issue 2236683002: Remove wrapping of mojo::Callbacks in std::unique_ptr. (Closed)

Created:
4 years, 4 months ago by Reilly Grant (use Gerrit)
Modified:
4 years, 4 months ago
CC:
Aaron Boodman, abarth-chromium, ben+mojo_chromium.org, chromium-reviews, darin (slow to review), qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove wrapping of mojo::Callbacks in std::unique_ptr. This wrapping was added in r355704 because at the time mojo::Callbacks did not like being freed on arbitrary threads, which would happen if they were passed to //device/usb APIs. This is no longer an issue so the wrapping can be removed. BUG=None Committed: https://crrev.com/c2dc1ac6393b162be226c84438ec4a39cef7d558 Cr-Commit-Position: refs/heads/master@{#412582}

Patch Set 1 #

Patch Set 2 : Rebased. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+20 lines, -31 lines) Patch
M device/usb/mojo/device_impl.cc View 1 10 chunks +20 lines, -31 lines 0 comments Download

Messages

Total messages: 14 (8 generated)
Reilly Grant (use Gerrit)
PTAL, it looks like this hasn't broken anything.
4 years, 4 months ago (2016-08-10 20:23:50 UTC) #3
Ken Rockot(use gerrit already)
lgtm
4 years, 4 months ago (2016-08-17 14:51:39 UTC) #7
Reilly Grant (use Gerrit)
Rebased.
4 years, 4 months ago (2016-08-17 17:01:38 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2236683002/20001
4 years, 4 months ago (2016-08-17 17:02:47 UTC) #11
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 4 months ago (2016-08-17 17:59:05 UTC) #12
commit-bot: I haz the power
4 years, 4 months ago (2016-08-17 18:06:10 UTC) #14
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/c2dc1ac6393b162be226c84438ec4a39cef7d558
Cr-Commit-Position: refs/heads/master@{#412582}

Powered by Google App Engine
This is Rietveld 408576698