Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4062)

Unified Diff: chrome/browser/ui/webui/settings/reset_settings_handler.cc

Issue 2236663002: Add origin of settings reset request to feedback reports. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Move cct hash definition to options::ResetProfileSettingsHandler Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/ui/webui/options/reset_profile_settings_handler.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/ui/webui/settings/reset_settings_handler.cc
diff --git a/chrome/browser/ui/webui/settings/reset_settings_handler.cc b/chrome/browser/ui/webui/settings/reset_settings_handler.cc
index c84a2a17d5e5a4b79a97c76b56e20069e83276ca..6ede5f095966b26b03d47d4616409a4ddca3a45a 100644
--- a/chrome/browser/ui/webui/settings/reset_settings_handler.cc
+++ b/chrome/browser/ui/webui/settings/reset_settings_handler.cc
@@ -132,8 +132,16 @@ void ResetSettingsHandler::OnResetProfileSettingsDone(
setting_snapshot_->Subtract(current_snapshot);
std::unique_ptr<reset_report::ChromeResetReport> report_proto =
SerializeSettingsReportToProto(*setting_snapshot_, difference);
- if (report_proto)
+ if (report_proto) {
+ // The material design version of the settings page currently does not
+ // expose the alternative ways, made available by the old settings page,
+ // to get to the reset settings dialog. Until those are available, we
+ // can assume that all reset requests came directly from user
+ // navigation.
+ report_proto->set_reset_request_origin(
+ reset_report::ChromeResetReport::RESET_REQUEST_ORIGIN_USER_CLICK);
SendSettingsFeedbackProto(*report_proto, profile_);
+ }
}
}
setting_snapshot_.reset();
« no previous file with comments | « chrome/browser/ui/webui/options/reset_profile_settings_handler.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698