Add origin of settings reset request to feedback reports.

chrome/browser/resources/options/triggered_reset_profile_settings_overlay.js

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 cr.define('options', function() {
   var Page = cr.ui.pageManager.Page;
 
   var ResetProfileSettingsOverlay = options.ResetProfileSettingsOverlay;
 
   /**
    * TriggeredResetProfileSettingsOverlay class
    * Encapsulated handling of the triggered variant of the 'Reset Profile
    * Settings' overlay page. Identical to ResetProfileSettingsOverlay but in a
    * new class to get a new overlay url mapping. See
    * triggered_profile_resetter.h for when this will be used.
    * @constructor
    * @extends {options.ResetProfileSettingsOverlay}
    */
   function TriggeredResetProfileSettingsOverlay() {
     // Note here that 'reset-profile-settings-overlay' is intentionally used as
     // the pageDivName argument to reuse the layout and CSS from the reset
     // profile settings overlay defined in reset_profile_settings_overlay.js.
     Page.call(this, 'triggeredResetProfileSettings',

[Dan Beam, 2016/09/13 18:42:10]

do

options.ResetProfileSettingsOverlay.call(this, ... name parameter ...)

what an element @extends and what is .call()'d as a construction should match. 
this code is bad for not doing that.

               loadTimeData.getString('triggeredResetProfileSettingsOverlay'),
               'reset-profile-settings-overlay');

[Dan Beam, 2016/09/06 19:35:18]

this constructor should be doing something like

ResetProfileSettingsOverlay.call(this);

to actually call the super

[alito, 2016/09/13 02:02:00]

But wouldn't that result in Page's constructor being called with
ResetProfileSettingsOverlay's name and title instead of the ones used here?

I could instead add parameters to the constructor of ResetProfileSettingsOverlay
so it would accept name and title to be passed to Page's constructor. Is that
what you had in mind?

[Dan Beam, 2016/09/13 18:42:10]

yes, add a name parameter

[alito, 2016/09/16 02:10:37]

This was parameterized in a different CL:
https://codereview.chromium.org/2334003006/

   }
 
   cr.addSingletonGetter(TriggeredResetProfileSettingsOverlay);
 
   TriggeredResetProfileSettingsOverlay.prototype = {
     __proto__: ResetProfileSettingsOverlay.prototype,
 
     /** @override */
     didShowPage: function() {
+      ResetProfileSettingsOverlay.getInstance().resetRequestOrigin_ =
+          'triggeredreset';

[Dan Beam, 2016/09/06 19:35:18]

this.resetRequestOrigin_ = 'triggeredreset';

[Dan Beam, 2016/09/13 18:42:10]

do this

[alito, 2016/09/16 02:10:37]

This is now taken care of by ResetProfileSettingsOverlay.

+
       $('reset-profile-settings-title').textContent =
           loadTimeData.getString('triggeredResetProfileSettingsOverlay');
       $('reset-profile-settings-explanation').textContent =
           loadTimeData.getString('triggeredResetProfileSettingsExplanation');
       chrome.send('onShowResetProfileDialog');
     },
   };
 
   // Export
   return {
     TriggeredResetProfileSettingsOverlay: TriggeredResetProfileSettingsOverlay
   };
 });