Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(243)

Side by Side Diff: chrome/browser/ui/webui/options/reset_profile_settings_handler.cc

Issue 2236663002: Add origin of settings reset request to feedback reports. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Small change in proto enum order. Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2013 The Chromium Authors. All rights reserved. 1 // Copyright 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/ui/webui/options/reset_profile_settings_handler.h" 5 #include "chrome/browser/ui/webui/options/reset_profile_settings_handler.h"
6 6
7 #include <utility> 7 #include <utility>
8 8
9 #include "base/bind.h" 9 #include "base/bind.h"
10 #include "base/bind_helpers.h" 10 #include "base/bind_helpers.h"
(...skipping 18 matching lines...) Expand all
29 #include "content/public/browser/web_ui.h" 29 #include "content/public/browser/web_ui.h"
30 #include "ui/base/l10n/l10n_util.h" 30 #include "ui/base/l10n/l10n_util.h"
31 31
32 #if defined(OS_WIN) 32 #if defined(OS_WIN)
33 #include "chrome/browser/profile_resetter/triggered_profile_resetter.h" 33 #include "chrome/browser/profile_resetter/triggered_profile_resetter.h"
34 #include "chrome/browser/profile_resetter/triggered_profile_resetter_factory.h" 34 #include "chrome/browser/profile_resetter/triggered_profile_resetter_factory.h"
35 #endif // defined(OS_WIN) 35 #endif // defined(OS_WIN)
36 36
37 namespace options { 37 namespace options {
38 38
39 namespace {
40
41 reset_report::ChromeResetReport::ResetRequestOrigin
42 ResetRequestOriginFromString(const std::string& reset_request_origin) {
43 static const char kOriginUserClick[] = "userclick";
44 static const char kOriginCct[] = "cct";
45 static const char kOriginTriggeredReset[] = "triggeredreset";
46
47 if (reset_request_origin == kOriginUserClick)
48 return reset_report::ChromeResetReport::RESET_REQUEST_ORIGIN_USER_CLICK;
49 if (reset_request_origin == kOriginCct)
50 return reset_report::ChromeResetReport::RESET_REQUEST_ORIGIN_CCT;
51 if (reset_request_origin == kOriginTriggeredReset) {
52 return reset_report::ChromeResetReport::
53 RESET_REQUEST_ORIGIN_TRIGGERED_RESET;
54 }
55 if (reset_request_origin.empty())
56 return reset_report::ChromeResetReport::RESET_REQUEST_ORIGIN_UNKNOWN;
57
58 NOTREACHED() << reset_request_origin;
59 return reset_report::ChromeResetReport::RESET_REQUEST_ORIGIN_UNKNOWN;
Dan Beam 2016/09/16 06:29:41 if (!reset_requeat_origin.empty()) NOTREACHED();
alito 2016/09/16 17:10:18 Done.
60 }
61
62 } // namespace
63
39 ResetProfileSettingsHandler::ResetProfileSettingsHandler() { 64 ResetProfileSettingsHandler::ResetProfileSettingsHandler() {
40 google_brand::GetBrand(&brandcode_); 65 google_brand::GetBrand(&brandcode_);
41 } 66 }
42 67
43 ResetProfileSettingsHandler::~ResetProfileSettingsHandler() {} 68 ResetProfileSettingsHandler::~ResetProfileSettingsHandler() {}
44 69
45 void ResetProfileSettingsHandler::InitializeHandler() { 70 void ResetProfileSettingsHandler::InitializeHandler() {
46 Profile* profile = Profile::FromWebUI(web_ui()); 71 Profile* profile = Profile::FromWebUI(web_ui());
47 resetter_.reset(new ProfileResetter(profile)); 72 resetter_.reset(new ProfileResetter(profile));
48 } 73 }
(...skipping 71 matching lines...) Expand 10 before | Expand all | Expand 10 after
120 base::Bind(&ResetProfileSettingsHandler::OnShowResetProfileDialog, 145 base::Bind(&ResetProfileSettingsHandler::OnShowResetProfileDialog,
121 base::Unretained(this))); 146 base::Unretained(this)));
122 web_ui()->RegisterMessageCallback("onHideResetProfileDialog", 147 web_ui()->RegisterMessageCallback("onHideResetProfileDialog",
123 base::Bind(&ResetProfileSettingsHandler::OnHideResetProfileDialog, 148 base::Bind(&ResetProfileSettingsHandler::OnHideResetProfileDialog,
124 base::Unretained(this))); 149 base::Unretained(this)));
125 } 150 }
126 151
127 void ResetProfileSettingsHandler::HandleResetProfileSettings( 152 void ResetProfileSettingsHandler::HandleResetProfileSettings(
128 const base::ListValue* value) { 153 const base::ListValue* value) {
129 bool send_settings = false; 154 bool send_settings = false;
130 bool success = value->GetBoolean(0, &send_settings); 155 std::string reset_request_origin;
156 bool success = value->GetBoolean(0, &send_settings) &&
157 value->GetString(1, &reset_request_origin);
131 DCHECK(success); 158 DCHECK(success);
132 159
133 DCHECK(brandcode_.empty() || config_fetcher_); 160 DCHECK(brandcode_.empty() || config_fetcher_);
134 if (config_fetcher_ && config_fetcher_->IsActive()) { 161 if (config_fetcher_ && config_fetcher_->IsActive()) {
135 // Reset once the prefs are fetched. 162 // Reset once the prefs are fetched.
136 config_fetcher_->SetCallback( 163 config_fetcher_->SetCallback(
137 base::Bind(&ResetProfileSettingsHandler::ResetProfile, 164 base::Bind(&ResetProfileSettingsHandler::ResetProfile, Unretained(this),
138 Unretained(this), 165 send_settings, reset_request_origin));
139 send_settings));
140 } else { 166 } else {
141 ResetProfile(send_settings); 167 ResetProfile(send_settings, reset_request_origin);
142 } 168 }
143 } 169 }
144 170
145 void ResetProfileSettingsHandler::OnResetProfileSettingsDone( 171 void ResetProfileSettingsHandler::OnResetProfileSettingsDone(
146 bool send_feedback) { 172 bool send_feedback,
173 const std::string& reset_request_origin) {
147 web_ui()->CallJavascriptFunctionUnsafe( 174 web_ui()->CallJavascriptFunctionUnsafe(
148 "ResetProfileSettingsOverlay.doneResetting"); 175 "ResetProfileSettingsOverlay.doneResetting");
149 if (send_feedback && setting_snapshot_) { 176 if (send_feedback && setting_snapshot_) {
150 Profile* profile = Profile::FromWebUI(web_ui()); 177 Profile* profile = Profile::FromWebUI(web_ui());
151 ResettableSettingsSnapshot current_snapshot(profile); 178 ResettableSettingsSnapshot current_snapshot(profile);
152 int difference = setting_snapshot_->FindDifferentFields(current_snapshot); 179 int difference = setting_snapshot_->FindDifferentFields(current_snapshot);
153 if (difference) { 180 if (difference) {
154 setting_snapshot_->Subtract(current_snapshot); 181 setting_snapshot_->Subtract(current_snapshot);
155 std::unique_ptr<reset_report::ChromeResetReport> report_proto = 182 std::unique_ptr<reset_report::ChromeResetReport> report_proto =
156 SerializeSettingsReportToProto(*setting_snapshot_, difference); 183 SerializeSettingsReportToProto(*setting_snapshot_, difference);
157 if (report_proto) 184 if (report_proto) {
185 report_proto->set_reset_request_origin(
186 ResetRequestOriginFromString(reset_request_origin));
158 SendSettingsFeedbackProto(*report_proto, profile); 187 SendSettingsFeedbackProto(*report_proto, profile);
188 }
159 } 189 }
160 } 190 }
161 setting_snapshot_.reset(); 191 setting_snapshot_.reset();
162 } 192 }
163 193
164 void ResetProfileSettingsHandler::OnShowResetProfileDialog( 194 void ResetProfileSettingsHandler::OnShowResetProfileDialog(
165 const base::ListValue* value) { 195 const base::ListValue* value) {
166 if (!resetter_->IsActive()) { 196 if (!resetter_->IsActive()) {
167 setting_snapshot_.reset( 197 setting_snapshot_.reset(
168 new ResettableSettingsSnapshot(Profile::FromWebUI(web_ui()))); 198 new ResettableSettingsSnapshot(Profile::FromWebUI(web_ui())));
(...skipping 16 matching lines...) Expand all
185 if (!resetter_->IsActive()) 215 if (!resetter_->IsActive())
186 setting_snapshot_.reset(); 216 setting_snapshot_.reset();
187 } 217 }
188 218
189 void ResetProfileSettingsHandler::OnSettingsFetched() { 219 void ResetProfileSettingsHandler::OnSettingsFetched() {
190 DCHECK(config_fetcher_); 220 DCHECK(config_fetcher_);
191 DCHECK(!config_fetcher_->IsActive()); 221 DCHECK(!config_fetcher_->IsActive());
192 // The master prefs is fetched. We are waiting for user pressing 'Reset'. 222 // The master prefs is fetched. We are waiting for user pressing 'Reset'.
193 } 223 }
194 224
195 void ResetProfileSettingsHandler::ResetProfile(bool send_settings) { 225 void ResetProfileSettingsHandler::ResetProfile(
226 bool send_settings,
227 const std::string& reset_request_origin) {
196 DCHECK(resetter_); 228 DCHECK(resetter_);
197 DCHECK(!resetter_->IsActive()); 229 DCHECK(!resetter_->IsActive());
198 230
199 std::unique_ptr<BrandcodedDefaultSettings> default_settings; 231 std::unique_ptr<BrandcodedDefaultSettings> default_settings;
200 if (config_fetcher_) { 232 if (config_fetcher_) {
201 DCHECK(!config_fetcher_->IsActive()); 233 DCHECK(!config_fetcher_->IsActive());
202 default_settings = config_fetcher_->GetSettings(); 234 default_settings = config_fetcher_->GetSettings();
203 config_fetcher_.reset(); 235 config_fetcher_.reset();
204 } else { 236 } else {
205 DCHECK(brandcode_.empty()); 237 DCHECK(brandcode_.empty());
206 } 238 }
207 239
208 // If failed to fetch BrandcodedDefaultSettings or this is an organic 240 // If failed to fetch BrandcodedDefaultSettings or this is an organic
209 // installation, use default settings. 241 // installation, use default settings.
210 if (!default_settings) 242 if (!default_settings)
211 default_settings.reset(new BrandcodedDefaultSettings); 243 default_settings.reset(new BrandcodedDefaultSettings);
212 resetter_->Reset( 244 resetter_->Reset(
213 ProfileResetter::ALL, std::move(default_settings), 245 ProfileResetter::ALL, std::move(default_settings),
214 base::Bind(&ResetProfileSettingsHandler::OnResetProfileSettingsDone, 246 base::Bind(&ResetProfileSettingsHandler::OnResetProfileSettingsDone,
215 AsWeakPtr(), send_settings)); 247 AsWeakPtr(), send_settings, reset_request_origin));
216 content::RecordAction(base::UserMetricsAction("ResetProfile")); 248 content::RecordAction(base::UserMetricsAction("ResetProfile"));
217 UMA_HISTOGRAM_BOOLEAN("ProfileReset.SendFeedback", send_settings); 249 UMA_HISTOGRAM_BOOLEAN("ProfileReset.SendFeedback", send_settings);
218 } 250 }
219 251
220 void ResetProfileSettingsHandler::UpdateFeedbackUI() { 252 void ResetProfileSettingsHandler::UpdateFeedbackUI() {
221 if (!setting_snapshot_) 253 if (!setting_snapshot_)
222 return; 254 return;
223 std::unique_ptr<base::ListValue> list = GetReadableFeedbackForSnapshot( 255 std::unique_ptr<base::ListValue> list = GetReadableFeedbackForSnapshot(
224 Profile::FromWebUI(web_ui()), *setting_snapshot_); 256 Profile::FromWebUI(web_ui()), *setting_snapshot_);
225 base::DictionaryValue feedback_info; 257 base::DictionaryValue feedback_info;
226 feedback_info.Set("feedbackInfo", list.release()); 258 feedback_info.Set("feedbackInfo", list.release());
227 web_ui()->CallJavascriptFunctionUnsafe( 259 web_ui()->CallJavascriptFunctionUnsafe(
228 "ResetProfileSettingsOverlay.setFeedbackInfo", feedback_info); 260 "ResetProfileSettingsOverlay.setFeedbackInfo", feedback_info);
229 } 261 }
230 262
231 } // namespace options 263 } // namespace options
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698