Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(268)

Issue 2236653002: Revert of Disable testCloseFiveIncognitoTab* tests (Closed)

Created:
4 years, 4 months ago by Theresa
Modified:
4 years, 4 months ago
Reviewers:
perezju, gone
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Disable testCloseFiveIncognitoTab* tests (patchset #1 id:1 of https://codereview.chromium.org/2232883002/ ) Reason for revert: The suspected CL was reverted and the current Android Tests(dbg) build #35666 with that revert is passing on the testCloseFiveIncognitoTab* tests. Reverting this CL so that we still get test coverage (these are important tests). Original issue's description: > Disable testCloseFiveIncognitoTab* tests > > Tests are failing on Android Tests (dbg), and Jelly Bean Tester. > > TBR=dfalcantara@chromium.org,twellington@chromium.org > BUG=636344 > > Committed: https://crrev.com/af7dfbe1caf07ba720221ed293818a89674e71ed > Cr-Commit-Position: refs/heads/master@{#411038} TBR=dfalcantara@chromium.org,perezju@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=636344 Committed: https://crrev.com/ab524b85b109a71c36d98146405af0db9bd02fcb Cr-Commit-Position: refs/heads/master@{#411085}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -12 lines) Patch
M chrome/android/javatests/src/org/chromium/chrome/browser/TabsTest.java View 2 chunks +4 lines, -12 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
Theresa
Created Revert of Disable testCloseFiveIncognitoTab* tests
4 years, 4 months ago (2016-08-10 18:11:26 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2236653002/1
4 years, 4 months ago (2016-08-10 18:12:36 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 4 months ago (2016-08-10 18:13:18 UTC) #4
commit-bot: I haz the power
4 years, 4 months ago (2016-08-10 18:15:19 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/ab524b85b109a71c36d98146405af0db9bd02fcb
Cr-Commit-Position: refs/heads/master@{#411085}

Powered by Google App Engine
This is Rietveld 408576698