Throw when case mapping result > max string length

Throw when case mapping result > max string length

Throw 'Range Error: invalid string length' when the result of
case mapping is longer than the max string length (kMaxLength in
objects.h = 1 << 28 - 16).

This is for case mapping with ICU.

BUG=v8:5271
TEST=intl/general/case-mapping.js with --icu_case_mapping

Committed: https://crrev.com/c7a2046670468b900b9dbbb4ce45beb5e0e717fd
Cr-Commit-Position: refs/heads/master@{#38565}

[jungshik at Google, 2016-08-10 19:04:02]

Description was changed from

==========
Throw when case mapping result > max string length

Throw 'Range Error: invalid string length' when the result of
case mapping is longer than the max string length (kMaxLength in
objects.h = 1 << 28 - 16).

This is for case mapping with ICU.

BUG=v8:5271
TEST=See the bug.
==========

to

==========
Throw when case mapping result > max string length

Throw 'Range Error: invalid string length' when the result of
case mapping is longer than the max string length (kMaxLength in
objects.h = 1 << 28 - 16).

This is for case mapping with ICU.

BUG=v8:5271
TEST=intl/general/case-mapping.js with --icu_case_mapping
==========

[jungshik at Google, 2016-08-10 19:04:03]

jshin@chromium.org changed reviewers:
+ littledan@chromium.org

[jungshik at Google, 2016-08-10 19:04:23]

PTAL. Thanks

[Dan Ehrenberg, 2016-08-10 19:06:23]

lgtm

https://codereview.chromium.org/2236593002/diff/20001/test/intl/general/case-...
File test/intl/general/case-mapping.js (right):

https://codereview.chromium.org/2236593002/diff/20001/test/intl/general/case-...
test/intl/general/case-mapping.js:152: invalidValues.forEach(function(value) {
Wouldn't this be a great place to use destructuring? function({s, locale,
opType})... :)

[Dan Ehrenberg, 2016-08-10 19:08:02]

lgtm

Small nit, but fine to submit as is.

https://codereview.chromium.org/2236593002/diff/20001/test/intl/general/case-...
File test/intl/general/case-mapping.js (right):

https://codereview.chromium.org/2236593002/diff/20001/test/intl/general/case-...
test/intl/general/case-mapping.js:172: assertEquals('RangeError', error.name);
You could also do assertThrows(() => s.toLocaleUpperCase(value.locale),
RangeError).

[jungshik at Google, 2016-08-10 20:18:10]

On 2016/08/10 19:08:02, Dan Ehrenberg wrote:
> lgtm
> 
> Small nit, but fine to submit as is.
> 
>
https://codereview.chromium.org/2236593002/diff/20001/test/intl/general/case-...
> File test/intl/general/case-mapping.js (right):
> 
>
https://codereview.chromium.org/2236593002/diff/20001/test/intl/general/case-...
> test/intl/general/case-mapping.js:172: assertEquals('RangeError', error.name);
> You could also do assertThrows(() => s.toLocaleUpperCase(value.locale),
> RangeError).

Thanks. It's nice. PS 3 uses both AssertThrows() and destructuring.

[Dan Ehrenberg, 2016-08-10 20:58:05]

lgtm

[jungshik at Google, 2016-08-10 21:11:03]

The CQ bit was checked by jshin@chromium.org

[commit-bot: I haz the power, 2016-08-10 21:11:06]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-10 21:45:56]

Description was changed from

==========
Throw when case mapping result > max string length

Throw 'Range Error: invalid string length' when the result of
case mapping is longer than the max string length (kMaxLength in
objects.h = 1 << 28 - 16).

This is for case mapping with ICU.

BUG=v8:5271
TEST=intl/general/case-mapping.js with --icu_case_mapping
==========

to

==========
Throw when case mapping result > max string length

Throw 'Range Error: invalid string length' when the result of
case mapping is longer than the max string length (kMaxLength in
objects.h = 1 << 28 - 16).

This is for case mapping with ICU.

BUG=v8:5271
TEST=intl/general/case-mapping.js with --icu_case_mapping
==========

[commit-bot: I haz the power, 2016-08-10 21:45:58]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-08-10 21:46:14]

Description was changed from

==========
Throw when case mapping result > max string length

Throw 'Range Error: invalid string length' when the result of
case mapping is longer than the max string length (kMaxLength in
objects.h = 1 << 28 - 16).

This is for case mapping with ICU.

BUG=v8:5271
TEST=intl/general/case-mapping.js with --icu_case_mapping
==========

to

==========
Throw when case mapping result > max string length

Throw 'Range Error: invalid string length' when the result of
case mapping is longer than the max string length (kMaxLength in
objects.h = 1 << 28 - 16).

This is for case mapping with ICU.

BUG=v8:5271
TEST=intl/general/case-mapping.js with --icu_case_mapping

Committed: https://crrev.com/c7a2046670468b900b9dbbb4ce45beb5e0e717fd
Cr-Commit-Position: refs/heads/master@{#38565}
==========

[commit-bot: I haz the power, 2016-08-10 21:46:15]

Patchset 3 (id:??) landed as
https://crrev.com/c7a2046670468b900b9dbbb4ce45beb5e0e717fd
Cr-Commit-Position: refs/heads/master@{#38565}

[Michael Achenbach, 2016-08-11 12:04:01]

A revert of this CL (patchset #4 id:60001) has been created in
https://codereview.chromium.org/2236343002/ by machenbach@chromium.org.

The reason for reverting is: The test is very flaky and made it on many
configurations into the top 10 of the slowest tests:

https://build.chromium.org/p/client.v8.ports/builders/V8%20Arm/builds/845
https://build.chromium.org/p/client.v8/builders/V8%20Win32%20-%20nosnap%20-%2...
https://build.chromium.org/p/client.v8/builders/V8%20Linux/builds/12369/steps....

[Michael Achenbach, 2016-08-11 13:39:04]

Patchset #4 (id:60001) has been deleted

[Michael Achenbach, 2016-08-11 13:39:29]

A revert of this CL (patchset #3 id:40001) has been created in
https://codereview.chromium.org/2236393002/ by machenbach@chromium.org.

The reason for reverting is: The test is very flaky and made it on many
configurations into the top 10 of the slowest tests:

https://build.chromium.org/p/client.v8.ports/builders/V8%20Arm/builds/845
https://build.chromium.org/p/client.v8/builders/V8%20Win32%20-%20nosnap%20-%2...
https://build.chromium.org/p/client.v8/builders/V8%20Linux/builds/12369/steps....

[Michael Achenbach, 2016-08-11 13:40:06]

I deleted patchset 4 because adding patchsets after a CL has landed blocks the
revert functionality.