Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(658)

Issue 2236583002: exo: Prevent maximize/minimize of shell surface in system modal container. (Closed)

Created:
4 years, 4 months ago by reveman
Modified:
4 years, 4 months ago
Reviewers:
oshima
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

exo: Prevent maximize/minimize of shell surface in system modal container. Preventing maximize will also prevent fullscreen mode from being entered. BUG=636430 Committed: https://crrev.com/79294dc1c7028268f419294d029537ebbf70f267 Cr-Commit-Position: refs/heads/master@{#411080}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -2 lines) Patch
M components/exo/shell_surface.cc View 1 chunk +4 lines, -2 lines 0 comments Download

Messages

Total messages: 14 (7 generated)
reveman
4 years, 4 months ago (2016-08-10 16:49:17 UTC) #2
oshima
lgtm I thought cros won't maximize windows in modal container. Is this just for safety ...
4 years, 4 months ago (2016-08-10 17:30:31 UTC) #7
reveman
On 2016/08/10 at 17:30:31, oshima wrote: > lgtm > > I thought cros won't maximize ...
4 years, 4 months ago (2016-08-10 17:34:21 UTC) #8
reveman
On 2016/08/10 at 17:34:21, reveman wrote: > On 2016/08/10 at 17:30:31, oshima wrote: > > ...
4 years, 4 months ago (2016-08-10 17:42:01 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2236583002/1
4 years, 4 months ago (2016-08-10 17:44:45 UTC) #11
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 4 months ago (2016-08-10 17:50:32 UTC) #12
commit-bot: I haz the power
4 years, 4 months ago (2016-08-10 17:52:10 UTC) #14
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/79294dc1c7028268f419294d029537ebbf70f267
Cr-Commit-Position: refs/heads/master@{#411080}

Powered by Google App Engine
This is Rietveld 408576698