Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(221)

Issue 2236573003: Update equalIgnoreCase to equalIgnoreASCIICase in Source/web (Closed)

Created:
4 years, 4 months ago by dsinclair
Modified:
4 years, 4 months ago
Reviewers:
tkent, esprehn, dmazzoni
CC:
aboxhall, blink-reviews, chromium-reviews, dmazzoni, je_julie, kinuko+watch, nektarios
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Update equalIgnoreCase to equalIgnoreASCIICase in Source/web This Cl updates the usage of equalIgnoreCase in Source/web to use equalsIgnoreASCIICase method instead. This better matches what the spec requires. BUG=627682 Committed: https://crrev.com/2d841fa9cb4c1cd9eb3dfb9329cc7b8119ad94ee Cr-Commit-Position: refs/heads/master@{#411549}

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -7 lines) Patch
M third_party/WebKit/Source/web/AssociatedURLLoaderTest.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/web/WebAXObject.cpp View 1 chunk +1 line, -1 line 2 comments Download
M third_party/WebKit/Source/web/WebDocument.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/web/WebElement.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/web/WebSearchableFormData.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/web/WebViewImpl.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/web/tests/FrameSerializerTest.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 19 (8 generated)
dsinclair
PTAL. These seemed like they were all candidates for conversion. Please let me know if ...
4 years, 4 months ago (2016-08-10 18:59:01 UTC) #4
esprehn
I'm happy with this if tkent is. :) lgtm
4 years, 4 months ago (2016-08-10 19:00:41 UTC) #5
dmazzoni
lgtm for WebAXObject.cpp I'm assuming you're planning to do the same for the rest of ...
4 years, 4 months ago (2016-08-10 19:18:12 UTC) #7
dsinclair
On 2016/08/10 19:18:12, dmazzoni wrote: > lgtm for WebAXObject.cpp > > I'm assuming you're planning ...
4 years, 4 months ago (2016-08-10 19:22:19 UTC) #8
dsinclair
tkent@ ping.
4 years, 4 months ago (2016-08-11 13:43:55 UTC) #11
tkent
https://codereview.chromium.org/2236573003/diff/1/third_party/WebKit/Source/web/WebAXObject.cpp File third_party/WebKit/Source/web/WebAXObject.cpp (right): https://codereview.chromium.org/2236573003/diff/1/third_party/WebKit/Source/web/WebAXObject.cpp#newcode241 third_party/WebKit/Source/web/WebAXObject.cpp:241: return equalIgnoringASCIICase(m_private->getAttribute(HTMLNames::aria_readonlyAttr), "true"); Are ARIA attribute values ascii-case-insensitive?
4 years, 4 months ago (2016-08-11 22:53:38 UTC) #12
esprehn
https://codereview.chromium.org/2236573003/diff/1/third_party/WebKit/Source/web/WebAXObject.cpp File third_party/WebKit/Source/web/WebAXObject.cpp (right): https://codereview.chromium.org/2236573003/diff/1/third_party/WebKit/Source/web/WebAXObject.cpp#newcode241 third_party/WebKit/Source/web/WebAXObject.cpp:241: return equalIgnoringASCIICase(m_private->getAttribute(HTMLNames::aria_readonlyAttr), "true"); On 2016/08/11 at 22:53:38, tkent wrote: ...
4 years, 4 months ago (2016-08-11 23:10:56 UTC) #13
tkent
lgtm
4 years, 4 months ago (2016-08-11 23:43:50 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2236573003/1
4 years, 4 months ago (2016-08-12 02:38:42 UTC) #16
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 4 months ago (2016-08-12 04:11:24 UTC) #17
commit-bot: I haz the power
4 years, 4 months ago (2016-08-12 04:14:21 UTC) #19
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/2d841fa9cb4c1cd9eb3dfb9329cc7b8119ad94ee
Cr-Commit-Position: refs/heads/master@{#411549}

Powered by Google App Engine
This is Rietveld 408576698