test/cctest/test-strings.cc - Issue 223653003: Return MaybeHandle from NewExternalStringFrom*.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: test/cctest/test-strings.cc

Issue 223653003: Return MaybeHandle from NewExternalStringFrom*. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge

Patch Set: Created 6 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: test/cctest/test-strings.cc

diff --git a/test/cctest/test-strings.cc b/test/cctest/test-strings.cc

index 6ff52003b8412ca1c8fc694df847f6ac475e3a38..4a60dcf811835579be207afa769ee167bdd8a208 100644

--- a/test/cctest/test-strings.cc

+++ b/test/cctest/test-strings.cc

@@ -1127,7 +1127,8 @@ TEST(SliceFromExternal) {

v8::HandleScope scope(CcTest::isolate());

AsciiVectorResource resource(

i::Vector<const char>("abcdefghijklmnopqrstuvwxyz", 26));

- Handle<String> string = factory->NewExternalStringFromAscii(&resource);

+ Handle<String> string =

+ factory->NewExternalStringFromAscii(&resource).ToHandleChecked();

CHECK(string->IsExternalString());

Handle<String> slice = factory->NewSubString(string, 1, 25);

CHECK(slice->IsSlicedString());

« no previous file with comments | « test/cctest/test-parsing.cc ('k') | no next file » | no next file with comments »