test/cctest/test-parsing.cc - Issue 223653003: Return MaybeHandle from NewExternalStringFrom*.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: test/cctest/test-parsing.cc

Issue 223653003: Return MaybeHandle from NewExternalStringFrom*. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge

Patch Set: Created 6 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: test/cctest/test-parsing.cc

diff --git a/test/cctest/test-parsing.cc b/test/cctest/test-parsing.cc

index e9429bf3858bffced84e5e6f73d2f194617efd6e..56d20f0b344db4db14ad7608780e2bc0f4e5819a 100644

--- a/test/cctest/test-parsing.cc

+++ b/test/cctest/test-parsing.cc

@@ -655,7 +655,7 @@ void TestCharacterStream(const char* ascii_source,

factory->NewStringFromAscii(ascii_vector));

TestExternalResource resource(uc16_buffer.get(), length);

i::Handle<i::String> uc16_string(

- factory->NewExternalStringFromTwoByte(&resource));

+ factory->NewExternalStringFromTwoByte(&resource).ToHandleChecked());

i::ExternalTwoByteStringUtf16CharacterStream uc16_stream(

i::Handle<i::ExternalTwoByteString>::cast(uc16_string), start, end);

« no previous file with comments | « test/cctest/test-api.cc ('k') | test/cctest/test-strings.cc » ('j') | no next file with comments »