src/factory.cc - Issue 223653003: Return MaybeHandle from NewExternalStringFrom*.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/factory.cc

Issue 223653003: Return MaybeHandle from NewExternalStringFrom*. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge

Patch Set: Created 6 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/factory.cc

diff --git a/src/factory.cc b/src/factory.cc

index 52a194180be30b9c675b83ef45d7ce06f137f45e..cfbd738d91ebd4337989e277c645fc8561666f23 100644

--- a/src/factory.cc

+++ b/src/factory.cc

@@ -518,7 +518,7 @@ Handle<String> Factory::NewProperSubString(Handle<String> str,

}

-Handle<String> Factory::NewExternalStringFromAscii(

+MaybeHandle<String> Factory::NewExternalStringFromAscii(

const ExternalAsciiString::Resource* resource) {

CALL_HEAP_FUNCTION(

isolate(),

@@ -527,7 +527,7 @@ Handle<String> Factory::NewExternalStringFromAscii(

}

-Handle<String> Factory::NewExternalStringFromTwoByte(

+MaybeHandle<String> Factory::NewExternalStringFromTwoByte(

const ExternalTwoByteString::Resource* resource) {

CALL_HEAP_FUNCTION(

isolate(),

« no previous file with comments | « src/factory.h ('k') | src/handles.h » ('j') | no next file with comments »