Issue 223653003: Return MaybeHandle from NewExternalStringFrom*.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 223653003: Return MaybeHandle from NewExternalStringFrom*. (Closed)

Created:
6 years, 8 months ago by Yang

Modified:
6 years, 8 months ago

Reviewers:
Igor Sheludko

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

Created: 6 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+23 lines, -22 lines)			Patch
M	src/api.cc	View	1 chunk	+4 lines, -8 lines	0 comments	Download
M	src/bootstrapper.cc	View	2 chunks	+6 lines, -6 lines	0 comments	Download
M	src/factory.h	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	src/factory.cc	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	src/handles.h	View	1 chunk	+2 lines, -0 lines	0 comments	Download
M	test/cctest/test-api.cc	View	1 chunk	+4 lines, -2 lines	0 comments	Download
M	test/cctest/test-parsing.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	test/cctest/test-strings.cc	View	1 chunk	+2 lines, -1 line	0 comments	Download

Total messages: 3 (0 generated)

Yang

6 years, 8 months ago (2014-04-03 12:41:45 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 manually as r20481 (presubmit successful).