Remove base::internal::InotifyReader's destructor.

Remove base::internal::InotifyReader's destructor.

InotifyReader is instantiated as a base::LazyInstance::Leaky object,
which is never properly destroyed, since commit 18c0fac7d ("Make
InotifyReader a leaky lazy instance").

Having a destructor that is never called causes build issues with GCC
6.1.1, so we can just remove it altogether:

  ../../base/files/file_path_watcher_linux.cc:276:1: error: 'base::{anonymous}::InotifyReader::~InotifyReader()' defined but not used [-Werror=unused-function]

While here, also remove all code related to |shutdown_pipe_| since it
was only used in conjunction with ~InotifyReader().

R=dcheng@chromium.org,mnissler@chromium.org,danakj@chromium.org,thestig@chromium.org
BUG=636346
Committed: https://crrev.com/983625d272c1b35a6297dd02c51fd1ee0fce3230
Cr-Commit-Position: refs/heads/master@{#411294}

[Raphael Kubo da Costa (rakuco), 2016-08-10 14:46:41]

ptal

[Mattias Nissler (ping if slow), 2016-08-10 14:59:30]

https://codereview.chromium.org/2236523002/diff/1/base/files/file_path_watche...
File base/files/file_path_watcher_linux.cc (left):

https://codereview.chromium.org/2236523002/diff/1/base/files/file_path_watche...
base/files/file_path_watcher_linux.cc:280: ssize_t ret =
HANDLE_EINTR(write(shutdown_pipe_[1], "", 1));
Removing this means that the shutdown_pipe will no longer be used, so that's
more dead code that should probably be removed.

[Raphael Kubo da Costa (rakuco), 2016-08-10 15:08:51]

Description was changed from

==========
Remove base::internal::InotifyReader's destructor.

InotifyReader is instantiated as a base::LazyInstance::Leaky object,
which is never properly destroyed, since commit 18c0fac7d ("Make
InotifyReader a leaky lazy instance").

Having a destructor that is never called causes build issues with GCC
6.1.1, so we can just remove it altogether:

  ../../base/files/file_path_watcher_linux.cc:276:1: error:
'base::{anonymous}::InotifyReader::~InotifyReader()' defined but not used
[-Werror=unused-function]

R=dcheng@chromium.org,mnissler@chromium.org,danakj@chromium.org,thestig@chrom...
BUG=636346
==========

to

==========
Remove base::internal::InotifyReader's destructor.

InotifyReader is instantiated as a base::LazyInstance::Leaky object,
which is never properly destroyed, since commit 18c0fac7d ("Make
InotifyReader a leaky lazy instance").

Having a destructor that is never called causes build issues with GCC
6.1.1, so we can just remove it altogether:

  ../../base/files/file_path_watcher_linux.cc:276:1: error:
'base::{anonymous}::InotifyReader::~InotifyReader()' defined but not used
[-Werror=unused-function]

While here, also remove all code related to |shutdown_pipe_| since it
was only used in conjunction with ~InotifyReader().

R=dcheng@chromium.org,mnissler@chromium.org,danakj@chromium.org,thestig@chrom...
BUG=636346
==========

[Raphael Kubo da Costa (rakuco), 2016-08-10 15:09:19]

Thanks for catching that. Patch v2 also removes all the code related to
shutdown_pipe_.

[danakj, 2016-08-10 17:34:16]

LGTM % nissler

[Mattias Nissler (ping if slow), 2016-08-11 09:07:19]

LGTM from my side, but I ain't got no powers here anyways ;)

[Raphael Kubo da Costa (rakuco), 2016-08-11 09:08:49]

The CQ bit was checked by raphael.kubo.da.costa@intel.com

[commit-bot: I haz the power, 2016-08-11 09:09:00]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-11 09:58:16]

Description was changed from

==========
Remove base::internal::InotifyReader's destructor.

InotifyReader is instantiated as a base::LazyInstance::Leaky object,
which is never properly destroyed, since commit 18c0fac7d ("Make
InotifyReader a leaky lazy instance").

Having a destructor that is never called causes build issues with GCC
6.1.1, so we can just remove it altogether:

  ../../base/files/file_path_watcher_linux.cc:276:1: error:
'base::{anonymous}::InotifyReader::~InotifyReader()' defined but not used
[-Werror=unused-function]

While here, also remove all code related to |shutdown_pipe_| since it
was only used in conjunction with ~InotifyReader().

R=dcheng@chromium.org,mnissler@chromium.org,danakj@chromium.org,thestig@chrom...
BUG=636346
==========

to

==========
Remove base::internal::InotifyReader's destructor.

InotifyReader is instantiated as a base::LazyInstance::Leaky object,
which is never properly destroyed, since commit 18c0fac7d ("Make
InotifyReader a leaky lazy instance").

Having a destructor that is never called causes build issues with GCC
6.1.1, so we can just remove it altogether:

  ../../base/files/file_path_watcher_linux.cc:276:1: error:
'base::{anonymous}::InotifyReader::~InotifyReader()' defined but not used
[-Werror=unused-function]

While here, also remove all code related to |shutdown_pipe_| since it
was only used in conjunction with ~InotifyReader().

R=dcheng@chromium.org,mnissler@chromium.org,danakj@chromium.org,thestig@chrom...
BUG=636346
==========

[commit-bot: I haz the power, 2016-08-11 09:58:17]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-08-11 09:59:44]

Description was changed from

==========
Remove base::internal::InotifyReader's destructor.

InotifyReader is instantiated as a base::LazyInstance::Leaky object,
which is never properly destroyed, since commit 18c0fac7d ("Make
InotifyReader a leaky lazy instance").

Having a destructor that is never called causes build issues with GCC
6.1.1, so we can just remove it altogether:

  ../../base/files/file_path_watcher_linux.cc:276:1: error:
'base::{anonymous}::InotifyReader::~InotifyReader()' defined but not used
[-Werror=unused-function]

While here, also remove all code related to |shutdown_pipe_| since it
was only used in conjunction with ~InotifyReader().

R=dcheng@chromium.org,mnissler@chromium.org,danakj@chromium.org,thestig@chrom...
BUG=636346
==========

to

==========
Remove base::internal::InotifyReader's destructor.

InotifyReader is instantiated as a base::LazyInstance::Leaky object,
which is never properly destroyed, since commit 18c0fac7d ("Make
InotifyReader a leaky lazy instance").

Having a destructor that is never called causes build issues with GCC
6.1.1, so we can just remove it altogether:

  ../../base/files/file_path_watcher_linux.cc:276:1: error:
'base::{anonymous}::InotifyReader::~InotifyReader()' defined but not used
[-Werror=unused-function]

While here, also remove all code related to |shutdown_pipe_| since it
was only used in conjunction with ~InotifyReader().

R=dcheng@chromium.org,mnissler@chromium.org,danakj@chromium.org,thestig@chrom...
BUG=636346

Committed: https://crrev.com/983625d272c1b35a6297dd02c51fd1ee0fce3230
Cr-Commit-Position: refs/heads/master@{#411294}
==========

[commit-bot: I haz the power, 2016-08-11 09:59:44]

Patchset 2 (id:??) landed as
https://crrev.com/983625d272c1b35a6297dd02c51fd1ee0fce3230
Cr-Commit-Position: refs/heads/master@{#411294}