telemetry/telemetry/internal/backends/chrome_inspector/devtools_client_backend_unittest.py - Issue 2236493003: [catapult android trybot] Make Telemetry tests run on Android

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: telemetry/telemetry/internal/backends/chrome_inspector/devtools_client_backend_unittest.py

Issue 2236493003: [catapult android trybot] Make Telemetry tests run on Android (Closed) Base URL: git@github.com:catapult-project/catapult.git@master

Patch Set: Add stack traces and more logging Created 4 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « telemetry/telemetry/internal/backends/chrome/tab_list_backend_unittest.py ('k') | telemetry/telemetry/internal/backends/chrome_inspector/inspector_memory_unittest.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: telemetry/telemetry/internal/backends/chrome_inspector/devtools_client_backend_unittest.py

diff --git a/telemetry/telemetry/internal/backends/chrome_inspector/devtools_client_backend_unittest.py b/telemetry/telemetry/internal/backends/chrome_inspector/devtools_client_backend_unittest.py

index 635a7c43b75141d7f591db1546843abce23626ee..b4cc7cf6ed02a5fd1e3a10201cd390864ec5b750 100644

--- a/telemetry/telemetry/internal/backends/chrome_inspector/devtools_client_backend_unittest.py

+++ b/telemetry/telemetry/internal/backends/chrome_inspector/devtools_client_backend_unittest.py

@@ -18,16 +18,22 @@ class DevToolsClientBackendTest(browser_test_case.BrowserTestCase):

def _devtools_client(self):

return self._browser_backend.devtools_client

+ # https://github.com/catapult-project/catapult/issues/3099

+ @decorators.Disabled('android')

def testGetChromeBranchNumber(self):

branch_num = self._devtools_client.GetChromeBranchNumber()

self.assertIsInstance(branch_num, int)

self.assertGreater(branch_num, 0)

+ # https://github.com/catapult-project/catapult/issues/3099

+ @decorators.Disabled('android')

def testIsAlive(self):

self.assertTrue(self._devtools_client.IsAlive())

+ # https://github.com/catapult-project/catapult/issues/3099 (Android)

+ # crbug.com/483212 (CrOS)

@decorators.Enabled('has tabs')

- @decorators.Disabled('chromeos') # crbug.com/483212

+ @decorators.Disabled('android', 'chromeos')

def testGetUpdatedInspectableContexts(self):

self._browser.tabs.New()

c1 = self._devtools_client.GetUpdatedInspectableContexts()