telemetry/telemetry/internal/actions/load_media_unittest.py - Issue 2236493003: [catapult android trybot] Make Telemetry tests run on Android

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: telemetry/telemetry/internal/actions/load_media_unittest.py

Issue 2236493003: [catapult android trybot] Make Telemetry tests run on Android (Closed) Base URL: git@github.com:catapult-project/catapult.git@master

Patch Set: Add stack traces and more logging Created 4 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « telemetry/telemetry/internal/actions/key_event_unittest.py ('k') | telemetry/telemetry/internal/actions/navigate_unittest.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: telemetry/telemetry/internal/actions/load_media_unittest.py

diff --git a/telemetry/telemetry/internal/actions/load_media_unittest.py b/telemetry/telemetry/internal/actions/load_media_unittest.py

index cdb7719e3622443536af320117ed01258a3af884..3dc01d3f738b1fce4d98344cf98e19d07b74f0fe 100644

--- a/telemetry/telemetry/internal/actions/load_media_unittest.py

+++ b/telemetry/telemetry/internal/actions/load_media_unittest.py

@@ -51,7 +51,9 @@ class LoadMediaActionTest(tab_test_case.TabTestCase):

self.assertFalse(self.eventFired('#video_1', 'canplaythrough'))

self.assertTrue(self.eventFired('#audio_1', 'canplaythrough'))

- @decorators.Disabled('linux') # crbug.com/418577

+ # https://github.com/catapult-project/catapult/issues/3099 (Android)

+ # crbug.com/418577 (Linux)

+ @decorators.Disabled('android', 'linux')

def testLoadWithAllSelector(self):

"""Both elements are loaded with selector='all'."""

action = LoadMediaAction(selector='all', timeout_in_seconds=5)

@@ -60,7 +62,9 @@ class LoadMediaActionTest(tab_test_case.TabTestCase):

self.assertTrue(self.eventFired('#video_1', 'canplaythrough'))

self.assertTrue(self.eventFired('#audio_1', 'canplaythrough'))

- @decorators.Disabled('linux') # crbug.com/418577

+ # https://github.com/catapult-project/catapult/issues/3099 (Android)

+ # crbug.com/418577 (Linux)

+ @decorators.Disabled('android', 'linux')

def testLoadRaisesAnExceptionOnTimeout(self):

"""The load action times out if the event does not fire."""

action = LoadMediaAction(selector='#video_1', timeout_in_seconds=0.1,