telemetry/telemetry/core/platform_unittest.py - Issue 2236493003: [catapult android trybot] Make Telemetry tests run on Android

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: telemetry/telemetry/core/platform_unittest.py

Issue 2236493003: [catapult android trybot] Make Telemetry tests run on Android (Closed) Base URL: git@github.com:catapult-project/catapult.git@master

Patch Set: Add stack traces and more logging Created 4 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « telemetry/telemetry/core/memory_cache_http_server_unittest.py ('k') | telemetry/telemetry/core/tracing_controller_unittest.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: telemetry/telemetry/core/platform_unittest.py

diff --git a/telemetry/telemetry/core/platform_unittest.py b/telemetry/telemetry/core/platform_unittest.py

index 5a838d2f9b171b178bb22ee1266fe334108ba7c5..cd202dacfcbc753a7473fded7cad4b854649296f 100644

--- a/telemetry/telemetry/core/platform_unittest.py

+++ b/telemetry/telemetry/core/platform_unittest.py

@@ -13,14 +13,18 @@ from telemetry.testing import tab_test_case

class PlatformScreenshotTest(tab_test_case.TabTestCase):

+ # https://github.com/catapult-project/catapult/issues/3099

+ @decorators.Disabled('android')

def testScreenshotSupported(self):

if self._platform.GetOSName() == 'android':

self.assertTrue(self._platform.CanTakeScreenshot())

# Run this test in serial to avoid multiple browsers pop up on the screen.

+ # https://github.com/catapult-project/catapult/issues/3099 (Android)

+ # crbug.com/563656 (Linux)

+ # crbug.com/660587 (Mac)

@decorators.Isolated

- @decorators.Disabled('linux') # crbug.com/563656

- @decorators.Disabled('mac') # crbug.com/660587

+ @decorators.Disabled('android', 'linux', 'mac')

def testScreenshot(self):

if not self._platform.CanTakeScreenshot():

self.skipTest('Platform does not support screenshots, skipping test.')