Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(136)

Issue 2236483005: EME: Add new event handler attributes (Closed)

Created:
4 years, 4 months ago by ddorwin
Modified:
4 years, 3 months ago
Reviewers:
jrummell, chrishtr, boliu
CC:
android-webview-reviews_chromium.org, blink-reviews, chromium-reviews, eric.carlson_apple.com, feature-media-reviews_chromium.org, haraken, mlamouri+watch-blink_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

EME: Add new event handler attributes Adds onwaitingforkey to HTMLMediaElement. Adds onkeystatuseschange and onmessage to MediaKeySession. BUG=635693 TEST=The three tests for these attributes in https://www.w3c-test.org/encrypted-media/idlharness.html Committed: https://crrev.com/6e3647df59a9b8a2c77d49ce5681e2a5b3ab7d17 Cr-Commit-Position: refs/heads/master@{#416988}

Patch Set 1 #

Patch Set 2 : Fix more results and update MediaKeySession syntax test #

Patch Set 3 : rebase only #

Unified diffs Side-by-side diffs Delta from patch set Stats (+37 lines, -8 lines) Patch
M android_webview/tools/system_webview_shell/test/data/webexposed/global-interface-listing-expected.txt View 1 2 4 chunks +6 lines, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/media/encrypted-media/encrypted-media-syntax.html View 1 2 2 chunks +8 lines, -8 lines 0 comments Download
M third_party/WebKit/LayoutTests/virtual/stable/webexposed/element-instance-property-listing-expected.txt View 1 2 2 chunks +2 lines, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/virtual/stable/webexposed/global-interface-listing-expected.txt View 1 2 4 chunks +6 lines, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/webexposed/element-instance-property-listing-expected.txt View 1 2 2 chunks +2 lines, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/webexposed/global-interface-listing-expected.txt View 1 2 4 chunks +6 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/modules/encryptedmedia/HTMLMediaElementEncryptedMedia.h View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/modules/encryptedmedia/HTMLMediaElementEncryptedMedia.idl View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/modules/encryptedmedia/MediaKeySession.h View 1 2 1 chunk +3 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/modules/encryptedmedia/MediaKeySession.idl View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 33 (22 generated)
ddorwin
4 years, 4 months ago (2016-08-11 21:01:37 UTC) #7
jrummell
lgtm
4 years, 4 months ago (2016-08-12 19:02:59 UTC) #12
ddorwin
Intent to Implement and Ship: https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/MF9Gk3bQjKo
4 years, 3 months ago (2016-09-02 22:38:15 UTC) #13
ddorwin
boliu: Please review changes in android_webview. chrishtr: Please review changes in webexposed expectations. I will ...
4 years, 3 months ago (2016-09-02 22:40:57 UTC) #15
boliu
the webview list was added to ensure new APIs added work in webview as well, ...
4 years, 3 months ago (2016-09-02 22:54:09 UTC) #16
chrishtr
lgtm
4 years, 3 months ago (2016-09-02 23:00:22 UTC) #17
ddorwin
On 2016/09/02 22:54:09, boliu wrote: > the webview list was added to ensure new APIs ...
4 years, 3 months ago (2016-09-02 23:10:30 UTC) #18
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2236483005/40001
4 years, 3 months ago (2016-09-06 19:47:54 UTC) #27
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2236483005/40001
4 years, 3 months ago (2016-09-07 16:20:19 UTC) #29
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 3 months ago (2016-09-07 17:49:13 UTC) #31
commit-bot: I haz the power
4 years, 3 months ago (2016-09-07 17:52:30 UTC) #33
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/6e3647df59a9b8a2c77d49ce5681e2a5b3ab7d17
Cr-Commit-Position: refs/heads/master@{#416988}

Powered by Google App Engine
This is Rietveld 408576698