Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(440)

Issue 2236463005: Remove iron-flex-layout from cr-network (Closed)

Created:
4 years, 4 months ago by michaelpg
Modified:
4 years, 3 months ago
Reviewers:
stevenjb
CC:
chromium-reviews, michaelpg+watch-elements_chromium.org, stevenjb+watch-md-settings_chromium.org, dbeam+watch-elements_chromium.org, oshima+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@IronFlex
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove iron-flex-layout from cr-network Helps in removing iron-flex-layout/classes. For cr-elements, this is the only dependency on those classes, so we can do away with those files entirely by just using normal CSS. BUG=635633 R=stevenjb@chromium.org CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+38 lines, -33 lines) Patch
M ui/webui/resources/cr_elements/network/cr_network_list.html View 3 chunks +5 lines, -4 lines 0 comments Download
M ui/webui/resources/cr_elements/network/cr_network_list_custom_item.html View 2 chunks +2 lines, -5 lines 0 comments Download
M ui/webui/resources/cr_elements/network/cr_network_list_item_css.html View 5 chunks +12 lines, -17 lines 0 comments Download
M ui/webui/resources/cr_elements/network/cr_network_list_network_item.html View 2 chunks +1 line, -2 lines 0 comments Download
M ui/webui/resources/cr_elements/network/cr_network_select.html View 2 chunks +18 lines, -5 lines 2 comments Download

Depends on Patchset:

Messages

Total messages: 2 (1 generated)
stevenjb
4 years, 4 months ago (2016-08-12 23:20:48 UTC) #2
lgtm

https://codereview.chromium.org/2236463005/diff/1/ui/webui/resources/cr_eleme...
File ui/webui/resources/cr_elements/network/cr_network_select.html (right):

https://codereview.chromium.org/2236463005/diff/1/ui/webui/resources/cr_eleme...
ui/webui/resources/cr_elements/network/cr_network_select.html:26: }
nit: FWIW I find all of these custom rules much less readable than the layout
classes.

That said, it sounds like there is a non trivial amount of overhead with
including the iron layout style, so for anything inside cr_elements/ it seems
reasonable to not include it.

https://codereview.chromium.org/2236463005/diff/1/ui/webui/resources/cr_eleme...
ui/webui/resources/cr_elements/network/cr_network_select.html:29: <header>
nit: I'd rather just use a div here. I don't think there is a clear consensus on
where we should use <header> vs <div>, and since we don't use it anywhere else
in settings, I would prefer not to start here.

Powered by Google App Engine
This is Rietveld 408576698