src/objects-debug.cc - Issue 2236443004: [turbofan] Introduce a dedicated ConvertTaggedHoleToUndefined operator.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/objects-debug.cc

Issue 2236443004: [turbofan] Introduce a dedicated ConvertTaggedHoleToUndefined operator. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: Fix verify heap. Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/objects-debug.cc

diff --git a/src/objects-debug.cc b/src/objects-debug.cc

index 13342ca36a405b187a862c54dca11a972d085f9e..b6ec9a2ac665ea2d2dc8f09d427d4b371bf6f3ce 100644

--- a/src/objects-debug.cc

+++ b/src/objects-debug.cc

@@ -601,7 +601,8 @@ void Oddball::OddballVerify() {

VerifyHeapPointer(to_string());

Object* number = to_number();

if (number->IsHeapObject()) {

- CHECK(number == heap->nan_value());

+ CHECK(number == heap->nan_value() ||

+ number == heap->hole_nan_value());

} else {

CHECK(number->IsSmi());

int value = Smi::cast(number)->value();

« no previous file with comments | « src/heap/heap.cc ('k') | src/types.h » ('j') | no next file with comments »