Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1)

Side by Side Diff: src/compiler/verifier.cc

Issue 2236443004: [turbofan] Introduce a dedicated ConvertTaggedHoleToUndefined operator. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Fix verify heap. Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « src/compiler/typer.cc ('k') | src/heap/heap.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2014 the V8 project authors. All rights reserved. 1 // Copyright 2014 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "src/compiler/verifier.h" 5 #include "src/compiler/verifier.h"
6 6
7 #include <algorithm> 7 #include <algorithm>
8 #include <deque> 8 #include <deque>
9 #include <queue> 9 #include <queue>
10 #include <sstream> 10 #include <sstream>
(...skipping 1024 matching lines...) Expand 10 before | Expand all | Expand 10 after
1035 case IrOpcode::kCheckedTaggedToFloat64: 1035 case IrOpcode::kCheckedTaggedToFloat64:
1036 case IrOpcode::kCheckedTruncateTaggedToWord32: 1036 case IrOpcode::kCheckedTruncateTaggedToWord32:
1037 break; 1037 break;
1038 1038
1039 case IrOpcode::kCheckFloat64Hole: 1039 case IrOpcode::kCheckFloat64Hole:
1040 CheckValueInputIs(node, 0, Type::Number()); 1040 CheckValueInputIs(node, 0, Type::Number());
1041 CheckUpperIs(node, Type::Number()); 1041 CheckUpperIs(node, Type::Number());
1042 break; 1042 break;
1043 case IrOpcode::kCheckTaggedHole: 1043 case IrOpcode::kCheckTaggedHole:
1044 CheckValueInputIs(node, 0, Type::Any()); 1044 CheckValueInputIs(node, 0, Type::Any());
1045 CheckUpperIs(node, Type::Any()); 1045 CheckUpperIs(node, Type::NonInternal());
1046 break;
1047 case IrOpcode::kConvertTaggedHoleToUndefined:
1048 CheckValueInputIs(node, 0, Type::Any());
1049 CheckUpperIs(node, Type::NonInternal());
1046 break; 1050 break;
1047 1051
1048 case IrOpcode::kLoadField: 1052 case IrOpcode::kLoadField:
1049 // Object -> fieldtype 1053 // Object -> fieldtype
1050 // TODO(rossberg): activate once machine ops are typed. 1054 // TODO(rossberg): activate once machine ops are typed.
1051 // CheckValueInputIs(node, 0, Type::Object()); 1055 // CheckValueInputIs(node, 0, Type::Object());
1052 // CheckUpperIs(node, FieldAccessOf(node->op()).type)); 1056 // CheckUpperIs(node, FieldAccessOf(node->op()).type));
1053 break; 1057 break;
1054 case IrOpcode::kLoadBuffer: 1058 case IrOpcode::kLoadBuffer:
1055 break; 1059 break;
(...skipping 520 matching lines...) Expand 10 before | Expand all | Expand 10 after
1576 replacement->op()->EffectOutputCount() > 0); 1580 replacement->op()->EffectOutputCount() > 0);
1577 DCHECK(!NodeProperties::IsFrameStateEdge(edge) || 1581 DCHECK(!NodeProperties::IsFrameStateEdge(edge) ||
1578 replacement->opcode() == IrOpcode::kFrameState); 1582 replacement->opcode() == IrOpcode::kFrameState);
1579 } 1583 }
1580 1584
1581 #endif // DEBUG 1585 #endif // DEBUG
1582 1586
1583 } // namespace compiler 1587 } // namespace compiler
1584 } // namespace internal 1588 } // namespace internal
1585 } // namespace v8 1589 } // namespace v8
OLDNEW
« no previous file with comments | « src/compiler/typer.cc ('k') | src/heap/heap.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698