Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1232)

Issue 2236443002: [gin] Use new SetAlignedPointerInInteralFields api function (Closed)

Created:
4 years, 4 months ago by Camillo Bruni
Modified:
4 years, 3 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[gin] Use new SetAlignedPointerInInteralFields api function R=jochen@chromium.org BUG=chromium:630217 Committed: https://crrev.com/c0363fda786a59496d6170b33be55f96bdf3b06e Cr-Commit-Position: refs/heads/master@{#415651}

Patch Set 1 #

Total comments: 1

Patch Set 2 : addressing nit #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -2 lines) Patch
M gin/wrappable.cc View 1 1 chunk +4 lines, -2 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
Camillo Bruni
PTAL
4 years, 4 months ago (2016-08-10 08:51:11 UTC) #1
jochen (gone - plz use gerrit)
lgtm either way https://codereview.chromium.org/2236443002/diff/1/gin/wrappable.cc File gin/wrappable.cc (right): https://codereview.chromium.org/2236443002/diff/1/gin/wrappable.cc#newcode63 gin/wrappable.cc:63: void* values[] {info, this}; why not ...
4 years, 4 months ago (2016-08-23 12:55:47 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2236443002/20001
4 years, 3 months ago (2016-08-31 15:18:15 UTC) #5
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 3 months ago (2016-08-31 16:22:04 UTC) #6
commit-bot: I haz the power
4 years, 3 months ago (2016-08-31 16:24:56 UTC) #8
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/c0363fda786a59496d6170b33be55f96bdf3b06e
Cr-Commit-Position: refs/heads/master@{#415651}

Powered by Google App Engine
This is Rietveld 408576698