Do not mark prototype transitions link as weak in heap snapshot.

Do not mark prototype transitions link as weak in heap snapshot.

R=ulan@chromium.org

Committed: https://code.google.com/p/v8/source/detail?r=20490

[alph, 2014-04-03 11:55:48]

ptal

[ulan, 2014-04-03 13:31:34]

https://codereview.chromium.org/223643004/diff/1/src/heap-snapshot-generator.cc
File src/heap-snapshot-generator.cc (right):

https://codereview.chromium.org/223643004/diff/1/src/heap-snapshot-generator....
src/heap-snapshot-generator.cc:1336: MarkAsWeakContainer(transitions);
MarkTransitionArray visitor also visits Keys.

[alph, 2014-04-03 14:35:38]

https://codereview.chromium.org/223643004/diff/1/src/heap-snapshot-generator.cc
File src/heap-snapshot-generator.cc (right):

https://codereview.chromium.org/223643004/diff/1/src/heap-snapshot-generator....
src/heap-snapshot-generator.cc:1336: MarkAsWeakContainer(transitions);
On 2014/04/03 13:31:34, ulan wrote:
> MarkTransitionArray visitor also visits Keys.

yes, I saw that. I'd like to address that in a separate patch.
AFAICT currently the keys are field names (Strings) so they should have other
strong links.

[ulan, 2014-04-03 14:36:45]

On 2014/04/03 14:35:38, alph wrote:
>
https://codereview.chromium.org/223643004/diff/1/src/heap-snapshot-generator.cc
> File src/heap-snapshot-generator.cc (right):
> 
>
https://codereview.chromium.org/223643004/diff/1/src/heap-snapshot-generator....
> src/heap-snapshot-generator.cc:1336: MarkAsWeakContainer(transitions);
> On 2014/04/03 13:31:34, ulan wrote:
> > MarkTransitionArray visitor also visits Keys.
> 
> yes, I saw that. I'd like to address that in a separate patch.
> AFAICT currently the keys are field names (Strings) so they should have other
> strong links.

OK, LGTM

[alph, 2014-04-03 16:33:21]

Committed patchset #2 manually as r20490 (presubmit successful).