Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(690)

Issue 223643002: Enable Media condition parsing on the MQ parser (Closed)

Created:
6 years, 8 months ago by Yoav Weiss
Modified:
6 years, 8 months ago
Reviewers:
eseidel
CC:
blink-reviews, kenneth.christiansen, Yoav Weiss, ed+blinkwatch_opera.com, dglazkov+blink, apavlov+blink_chromium.org, darktears, rune+blink, rwlbuis
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Visibility:
Public.

Description

Enable Media condition parsing on the MQ parser Enable the MediaQueryParser to also parse media conditions on top of full media query sets. That is in preparation for the sizes attribute parser, that will use that functionality. BUG=357586 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=171025

Patch Set 1 #

Patch Set 2 : Working tests #

Patch Set 3 : Fixed clang errors #

Total comments: 1

Patch Set 4 : Rebased. Fixed nit. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+90 lines, -19 lines) Patch
M Source/core/core.gypi View 1 2 3 1 chunk +1 line, -0 lines 0 comments Download
M Source/core/css/MediaList.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/css/MediaQuery.cpp View 1 chunk +1 line, -1 line 0 comments Download
A Source/core/css/parser/MediaConditionTest.cpp View 1 2 1 chunk +54 lines, -0 lines 0 comments Download
M Source/core/css/parser/MediaQueryParser.h View 1 2 3 2 chunks +11 lines, -6 lines 0 comments Download
M Source/core/css/parser/MediaQueryParser.cpp View 1 2 3 3 chunks +21 lines, -10 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
Yoav Weiss
6 years, 8 months ago (2014-04-05 20:03:06 UTC) #1
eseidel
lgtm https://codereview.chromium.org/223643002/diff/40001/Source/core/css/parser/MediaQueryParser.h File Source/core/css/parser/MediaQueryParser.h (right): https://codereview.chromium.org/223643002/diff/40001/Source/core/css/parser/MediaQueryParser.h#newcode63 Source/core/css/parser/MediaQueryParser.h:63: virtual ~MediaQueryParser() { }; No need for this ...
6 years, 8 months ago (2014-04-07 22:33:12 UTC) #2
Yoav Weiss
The CQ bit was checked by yoav@yoav.ws
6 years, 8 months ago (2014-04-08 04:08:37 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/yoav@yoav.ws/223643002/40001
6 years, 8 months ago (2014-04-08 04:08:51 UTC) #4
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 8 months ago (2014-04-08 04:09:39 UTC) #5
commit-bot: I haz the power
Failed to apply patch for Source/core/core.gypi: While running patch -p1 --forward --force --no-backup-if-mismatch; patching file ...
6 years, 8 months ago (2014-04-08 04:09:39 UTC) #6
Yoav Weiss
The CQ bit was checked by yoav@yoav.ws
6 years, 8 months ago (2014-04-08 05:24:33 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/yoav@yoav.ws/223643002/60001
6 years, 8 months ago (2014-04-08 05:24:39 UTC) #8
commit-bot: I haz the power
6 years, 8 months ago (2014-04-08 05:35:18 UTC) #9
Message was sent while issue was closed.
Change committed as 171025

Powered by Google App Engine
This is Rietveld 408576698