Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(492)

Issue 2236423002: Inline fast path for GrPaint::isConstantBlendedColor when no color FPs and src-over blend. (Closed)

Created:
4 years, 4 months ago by bsalomon
Modified:
4 years, 4 months ago
Reviewers:
egdaniel
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Inline fast path for GrPaint::isConstantBlendedColor when no color FPs and src-over blend. GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2236423002 Committed: https://skia.googlesource.com/skia/+/198ca42c67aaabc2d7ffea4653b31323e496e7cc

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -3 lines) Patch
M include/gpu/GrPaint.h View 1 chunk +13 lines, -1 line 0 comments Download
M src/gpu/GrPaint.cpp View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 8 (4 generated)
bsalomon
I get a ~5% speedup on a skp captured from the overdraw benchmark.
4 years, 4 months ago (2016-08-11 14:11:52 UTC) #3
egdaniel
lgtm
4 years, 4 months ago (2016-08-11 14:16:38 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2236423002/1
4 years, 4 months ago (2016-08-11 14:18:03 UTC) #6
commit-bot: I haz the power
4 years, 4 months ago (2016-08-11 14:39:36 UTC) #8
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/198ca42c67aaabc2d7ffea4653b31323e496e7cc

Powered by Google App Engine
This is Rietveld 408576698