Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(256)

Issue 2236403002: [heap] Fix SizeOfObjects tests (Closed)

Created:
4 years, 4 months ago by Michael Lippautz
Modified:
4 years, 4 months ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[heap] Fix SizeOfObjects tests Use CollectAllAvailableGarbage for initial GC. R=hpayer@chromium.org BUG= Committed: https://crrev.com/d27d293879039666028bb2422db016c875b5f833 Cr-Commit-Position: refs/heads/master@{#38584}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -20 lines) Patch
M test/cctest/heap/test-heap.cc View 3 chunks +10 lines, -20 lines 0 comments Download

Messages

Total messages: 15 (8 generated)
Michael Lippautz
4 years, 4 months ago (2016-08-11 13:55:39 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2236403002/1
4 years, 4 months ago (2016-08-11 13:56:01 UTC) #3
commit-bot: I haz the power
No L-G-T-M from a valid reviewer yet. CQ run can only be started by full ...
4 years, 4 months ago (2016-08-11 13:56:02 UTC) #5
Hannes Payer (out of office)
LGTM
4 years, 4 months ago (2016-08-11 14:13:35 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2236403002/1
4 years, 4 months ago (2016-08-11 14:20:10 UTC) #12
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 4 months ago (2016-08-11 14:21:50 UTC) #13
commit-bot: I haz the power
4 years, 4 months ago (2016-08-11 14:22:09 UTC) #15
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/d27d293879039666028bb2422db016c875b5f833
Cr-Commit-Position: refs/heads/master@{#38584}

Powered by Google App Engine
This is Rietveld 408576698