chrome/browser/autocomplete/search_provider.cc - Issue 22364007: AutocompleteInput::PageClassification -> AutocompleteInput::OmniboxContext.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/autocomplete/search_provider.cc

Issue 22364007: AutocompleteInput::PageClassification -> AutocompleteInput::OmniboxContext. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 7 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/autocomplete/autocomplete_input.h ('K') | « chrome/browser/autocomplete/autocomplete_input.cc ('k') | chrome/browser/autocomplete/zero_suggest_provider.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/autocomplete/search_provider.cc

diff --git a/chrome/browser/autocomplete/search_provider.cc b/chrome/browser/autocomplete/search_provider.cc

index d4245fd34e8719b14b02a9213e22a51447052195..275fbb0e66b7c707536b864e52d268826a3cb2e2 100644

--- a/chrome/browser/autocomplete/search_provider.cc

+++ b/chrome/browser/autocomplete/search_provider.cc

@@ -626,8 +626,7 @@ void SearchProvider::DoHistoryQuery(bool minimal_changes) {

keyword_history_results_.clear();

default_history_results_.clear();

- if (OmniboxFieldTrial::SearchHistoryDisable(

- input_.current_page_classification()))

+ if (OmniboxFieldTrial::SearchHistoryDisable(input_.omnibox_context()))

return;

HistoryService* const history_service =

@@ -1201,8 +1200,7 @@ SearchProvider::SuggestResults SearchProvider::ScoreHistoryResults(

AutocompleteClassifierFactory::GetForProfile(profile_);

SuggestResults scored_results;

const bool prevent_search_history_inlining =

- OmniboxFieldTrial::SearchHistoryPreventInlining(

- input_.current_page_classification());

+ OmniboxFieldTrial::SearchHistoryPreventInlining(input_.omnibox_context());

for (HistoryResults::const_iterator i(results.begin()); i != results.end();

++i) {

// Don't autocomplete multi-word queries that have only been seen once