Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(112)

Issue 2236383002: Temporary hack to fix telemetry_perf_unittests flakes. (Closed)

Created:
4 years, 4 months ago by gab
Modified:
4 years, 4 months ago
CC:
chromium-reviews, asvitkine+watch_chromium.org, Alexei Svitkine (slow)
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Temporary hack to fix telemetry_perf_unittests flakes. While asvitkine@ works on proper fix. BUG=635255 Committed: https://crrev.com/18e3366f1863eb3a9f7a19211e184acc2f501e06 Cr-Commit-Position: refs/heads/master@{#411336}

Patch Set 1 #

Patch Set 2 : fix nullptr #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -1 line) Patch
M components/metrics/metrics_state_manager.cc View 1 1 chunk +5 lines, -1 line 0 comments Download

Messages

Total messages: 15 (9 generated)
gab
Rob PTAL (see bug for details)
4 years, 4 months ago (2016-08-11 13:26:14 UTC) #2
rkaplow
lgtm
4 years, 4 months ago (2016-08-11 14:19:55 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2236383002/20001
4 years, 4 months ago (2016-08-11 14:39:18 UTC) #10
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 4 months ago (2016-08-11 15:33:52 UTC) #11
commit-bot: I haz the power
Patchset 2 (id:??) landed as https://crrev.com/18e3366f1863eb3a9f7a19211e184acc2f501e06 Cr-Commit-Position: refs/heads/master@{#411336}
4 years, 4 months ago (2016-08-11 15:36:16 UTC) #13
Alexei Svitkine (slow)
4 years, 4 months ago (2016-08-11 23:24:46 UTC) #15
Message was sent while issue was closed.
LGTM - thanks Gab!

Powered by Google App Engine
This is Rietveld 408576698