components/ntp_snippets/content_suggestions_provider.h - Issue 2236303002: Make OfflinePage ContentSuggestions dismissable

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/ntp_snippets/content_suggestions_provider.h

Issue 2236303002: Make OfflinePage ContentSuggestions dismissable (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: base::Value --> std::unique_ptr<base::Value> Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: components/ntp_snippets/content_suggestions_provider.h

diff --git a/components/ntp_snippets/content_suggestions_provider.h b/components/ntp_snippets/content_suggestions_provider.h

index 2f343a47dc4bf918334e9eea8d58026f078bf55b..23d403c44dc5012e025e00df10fac45e96e07e5a 100644

--- a/components/ntp_snippets/content_suggestions_provider.h

+++ b/components/ntp_snippets/content_suggestions_provider.h

@@ -123,11 +123,12 @@ class ContentSuggestionsProvider {

// application-wide, because this provider is the only one that provides

// suggestions for that category.

std::string MakeUniqueID(Category category,

- const std::string& within_category_id);

+ const std::string& within_category_id) const;

// Reverse functions for MakeUniqueID()

- Category GetCategoryFromUniqueID(const std::string& unique_id);

- std::string GetWithinCategoryIDFromUniqueID(const std::string& unique_id);

+ Category GetCategoryFromUniqueID(const std::string& unique_id) const;

+ std::string GetWithinCategoryIDFromUniqueID(

+ const std::string& unique_id) const;

Observer* observer() const { return observer_; }

CategoryFactory* category_factory() const { return category_factory_; }