Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2236233002:
Adjust CSP of feedback extension (Closed)
|
Created:
4 years, 4 months ago by Sergey Shekyan Modified:
4 years, 4 months ago CC:
chromium-reviews, arv+watch_chromium.org, apacible+watch_chromium.org Base URL:
https://chromium.googlesource.com/chromium/src.git@master Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionAdjust CSP of feedback extension
Recent change to Content Security Policy matching algorithm for
"*" source-expression at https://codereview.chromium.org/2209113002/
requires to adjust policies that use "*" and assume that it will match
resource loads from schemes other than http/https/ws/wss.
This patch set updates img-src CSP directive of feedback extension
to allow loading images from `chrome:` scheme.
BUG=633044
R=jww@chromium.org
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
Committed: https://crrev.com/538be9a65c081269429400de49057ede4d50bd32
Cr-Commit-Position: refs/heads/master@{#411551}
Patch Set 1 #Patch Set 2 : resolving conflicts #Patch Set 3 : Trying to fix messed up conflict #Messages
Total messages: 27 (12 generated)
Description was changed from ========== Adjust CSP of feedback extension Recent change to Content Security Policy matching algorithm for "*" source-expression at https://codereview.chromium.org/2209113002/ requires to adjust policies that use "*" and assume that it will match resource loads from schemes other than http/https/ws/wss. This patch set updates img-src CSP directive of feedback extension to allow loading images from `chrome:` scheme. BUG=633044 R=jww@chromium.org ========== to ========== Adjust CSP of feedback extension Recent change to Content Security Policy matching algorithm for "*" source-expression at https://codereview.chromium.org/2209113002/ requires to adjust policies that use "*" and assume that it will match resource loads from schemes other than http/https/ws/wss. This patch set updates img-src CSP directive of feedback extension to allow loading images from `chrome:` scheme. BUG=633044 R=jww@chromium.org CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation ==========
On 2016/08/11 06:26:16, Sergey Shekyan wrote: > Description was changed from > > ========== > Adjust CSP of feedback extension > > Recent change to Content Security Policy matching algorithm for > "*" source-expression at https://codereview.chromium.org/2209113002/ > requires to adjust policies that use "*" and assume that it will match > resource loads from schemes other than http/https/ws/wss. > > This patch set updates img-src CSP directive of feedback extension > to allow loading images from `chrome:` scheme. > > BUG=633044 > mailto:R=jww@chromium.org > ========== > > to > > ========== > Adjust CSP of feedback extension > > Recent change to Content Security Policy matching algorithm for > "*" source-expression at https://codereview.chromium.org/2209113002/ > requires to adjust policies that use "*" and assume that it will match > resource loads from schemes other than http/https/ws/wss. > > This patch set updates img-src CSP directive of feedback extension > to allow loading images from `chrome:` scheme. > > BUG=633044 > mailto:R=jww@chromium.org > CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation > ========== jww@, would you please take a look at this? Similar to the previous one, but for blocked images, that are loaded by stylesheet that were blocked last time :(
lgtm
The CQ bit was checked by shekyan@gmail.com
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...) ios-device on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds...) ios-simulator on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...)
The CQ bit was checked by shekyan@gmail.com
The patchset sent to the CQ was uploaded after l-g-t-m from jww@chromium.org Link to the patchset: https://codereview.chromium.org/2236233002/#ps20001 (title: "resolving conflicts")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: android_arm64_dbg_recipe on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/android_arm6...) android_clang_dbg_recipe on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/android_clan...) cast_shell_android on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/cast_shell_a...) linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...) cast_shell_linux on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/cast_shell_linu...) chromeos_amd64-generic_chromium_compile_only_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_amd64-...) chromeos_daisy_chromium_compile_only_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_daisy_...) chromeos_x86-generic_chromium_compile_only_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_x86-ge...) linux_chromium_asan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...) linux_chromium_chromeos_compile_dbg_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...) linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...) linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...) linux_chromium_clobber_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...) linux_chromium_compile_dbg_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...) linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...) mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...) mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)
The CQ bit was checked by shekyan@gmail.com
The patchset sent to the CQ was uploaded after l-g-t-m from jww@chromium.org Link to the patchset: https://codereview.chromium.org/2236233002/#ps40001 (title: "Trying to fix messed up conflict")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)
jww@chromium.org changed reviewers: + thestig@chromium.org
thestig@chromium.org: Can you OWNER review this? Thanks!
On 2016/08/12 03:56:02, jww wrote: > mailto:thestig@chromium.org: Can you OWNER review this? Thanks! jww@, is that suppose to solve this presubmit failure? I think I messed up my branches and there are conflicts:( Should I create another clean CL?
The CQ bit was checked by thestig@chromium.org
lgtm
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Message was sent while issue was closed.
Committed patchset #3 (id:40001)
Message was sent while issue was closed.
Description was changed from ========== Adjust CSP of feedback extension Recent change to Content Security Policy matching algorithm for "*" source-expression at https://codereview.chromium.org/2209113002/ requires to adjust policies that use "*" and assume that it will match resource loads from schemes other than http/https/ws/wss. This patch set updates img-src CSP directive of feedback extension to allow loading images from `chrome:` scheme. BUG=633044 R=jww@chromium.org CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation ========== to ========== Adjust CSP of feedback extension Recent change to Content Security Policy matching algorithm for "*" source-expression at https://codereview.chromium.org/2209113002/ requires to adjust policies that use "*" and assume that it will match resource loads from schemes other than http/https/ws/wss. This patch set updates img-src CSP directive of feedback extension to allow loading images from `chrome:` scheme. BUG=633044 R=jww@chromium.org CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Committed: https://crrev.com/538be9a65c081269429400de49057ede4d50bd32 Cr-Commit-Position: refs/heads/master@{#411551} ==========
Message was sent while issue was closed.
Patchset 3 (id:??) landed as https://crrev.com/538be9a65c081269429400de49057ede4d50bd32 Cr-Commit-Position: refs/heads/master@{#411551}
Message was sent while issue was closed.
On 2016/08/12 04:26:20, commit-bot: I haz the power wrote: > Patchset 3 (id:??) landed as > https://crrev.com/538be9a65c081269429400de49057ede4d50bd32 > Cr-Commit-Position: refs/heads/master@{#411551} Yes, that's supposed to fix your CL ;-) |
