test/cctest/test-disasm-arm.cc - Issue 223623003: Fix fixed-point vcvt_f64_s32 immediate value encoding

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: test/cctest/test-disasm-arm.cc

Issue 223623003: Fix fixed-point vcvt_f64_s32 immediate value encoding (Closed) Base URL: git://github.com/v8/v8.git@master

Patch Set: Reorder bits for clarity Created 6 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: test/cctest/test-disasm-arm.cc

diff --git a/test/cctest/test-disasm-arm.cc b/test/cctest/test-disasm-arm.cc

index 5eff4206ca409c6707a1701a1d7af9d00fc5f6e9..24453bc88ebc683441921488f8dd428267425ac4 100644

--- a/test/cctest/test-disasm-arm.cc

+++ b/test/cctest/test-disasm-arm.cc

@@ -592,8 +592,8 @@ TEST(Vfp) {

"eeb80be0 vcvt.f64.s32 d0, s1");

COMPARE(vcvt_f32_s32(s0, s2),

"eeb80ac1 vcvt.f32.s32 s0, s2");

- COMPARE(vcvt_f64_s32(d0, 1),

- "eeba0bef vcvt.f64.s32 d0, d0, #1");

+ COMPARE(vcvt_f64_s32(d0, 2),

+ "eeba0bcf vcvt.f64.s32 d0, d0, #2");

if (CpuFeatures::IsSupported(VFP32DREGS)) {

COMPARE(vmov(d3, d27),

« no previous file with comments | « test/cctest/test-assembler-arm.cc ('k') | no next file » | no next file with comments »